From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#61396: diff mode could distinguish changed from deleted lines Date: Sun, 01 Oct 2023 11:54:58 -0400 Message-ID: References: <85f73356-3a11-c76c-dd9a-f2dc1f6ef504@gutov.dev> <86r0mf1rzl.fsf@mail.linkov.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="32097"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: Dmitry Gutov , 61396@debbugs.gnu.org, Samuel Wales To: Juri Linkov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sun Oct 01 17:56:02 2023 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1qmynY-0007xW-B3 for geb-bug-gnu-emacs@m.gmane-mx.org; Sun, 01 Oct 2023 17:56:00 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qmynN-0003Jj-FN; Sun, 01 Oct 2023 11:55:49 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qmynL-0003It-Pt for bug-gnu-emacs@gnu.org; Sun, 01 Oct 2023 11:55:47 -0400 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1qmynK-0000KU-VA for bug-gnu-emacs@gnu.org; Sun, 01 Oct 2023 11:55:47 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1qmynZ-0004rD-VO for bug-gnu-emacs@gnu.org; Sun, 01 Oct 2023 11:56:01 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Oct 2023 15:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 61396 X-GNU-PR-Package: emacs Original-Received: via spool by 61396-submit@debbugs.gnu.org id=B61396.169617573318632 (code B ref 61396); Sun, 01 Oct 2023 15:56:01 +0000 Original-Received: (at 61396) by debbugs.gnu.org; 1 Oct 2023 15:55:33 +0000 Original-Received: from localhost ([127.0.0.1]:35184 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmyn6-0004qS-LD for submit@debbugs.gnu.org; Sun, 01 Oct 2023 11:55:32 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:18000) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qmyn3-0004q8-S4 for 61396@debbugs.gnu.org; Sun, 01 Oct 2023 11:55:31 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id C815344283E; Sun, 1 Oct 2023 11:55:07 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1696175706; bh=yIcyJGnQdjhQcz/jMzUZPnEkS08lpLCxMJTROm1/JhM=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GgRvz5gICmeDfY+lVclApk3KI/PbeeYHLGt0Tj2eAM/bWUwC9S/ossDzdMNzlXzY5 GOAA/KyHP35CKe1wPKe1wUuO2KNEx+KOzJJb0RT7kSufZaQUAIa0Tv8x0V9iAD79V2 GPS36khLuqfxkwR9xaf4Tj5MPTfBZWmy5Jm3vZw4zpXqvf9WTCv1blaxQjjgc8nvv7 5AnVkaelXUqN/8/CspuH2mT4iFGzLyCCnMHYxndGUkz/kz8T+IZkZ11N7UWHf9nXgo LcdOGFddUYzTzZIVTRSC9HZQivSZWYbWsHsknRz7LbSjK5wHYvsfQ+dCXc4+EOd5cG 5XTd+Bs29hLuA== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 4FB7344270A; Sun, 1 Oct 2023 11:55:06 -0400 (EDT) Original-Received: from pastel (unknown [216.154.20.132]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 10F9A1201B4; Sun, 1 Oct 2023 11:55:06 -0400 (EDT) In-Reply-To: <86r0mf1rzl.fsf@mail.linkov.net> (Juri Linkov's message of "Sat, 30 Sep 2023 20:38:22 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:271627 Archived-At: >> I have been bitten several times in the past when going through largish >> diffs where I overlooked important things in the added/removed parts >> because they were colored the same was as the unchanged parts of >> changed lines and so I just glossed over them. > > I realized now the same problem exists even without color highlighting > at all. No, the problem I describe is specific to the "refined" diff highlighting: I rely on this highlighting to tell me what has "really" been changed, yet it's not applied to lines that are "just added" or "just removed" so I end up skipping over them unwittingly because they are highlighted identically to the *unchanged* parts of those lines which are otherwise changed. Stefan