From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#68690: Segmentation fault building with native-comp Date: Fri, 26 Jan 2024 08:48:46 -0500 Message-ID: References: <87wmryel78.fsf@pub.pink> <86zfwud5cv.fsf@gnu.org> <86sf2mcwa2.fsf@gnu.org> <86le8dd7ze.fsf@gnu.org> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="31897"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 68690@debbugs.gnu.org, jm@pub.pink, eliz@gnu.org To: Gerd =?UTF-8?Q?M=C3=B6llmann?= Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Fri Jan 26 14:50:21 2024 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1rTMb4-00081M-Sv for geb-bug-gnu-emacs@m.gmane-mx.org; Fri, 26 Jan 2024 14:50:19 +0100 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rTMak-0008NT-1o; Fri, 26 Jan 2024 08:49:58 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTMah-0008Mt-W0 for bug-gnu-emacs@gnu.org; Fri, 26 Jan 2024 08:49:56 -0500 Original-Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rTMah-0004HE-LY for bug-gnu-emacs@gnu.org; Fri, 26 Jan 2024 08:49:55 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rTMan-0003pe-Lb for bug-gnu-emacs@gnu.org; Fri, 26 Jan 2024 08:50:01 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 26 Jan 2024 13:50:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68690 X-GNU-PR-Package: emacs X-Debbugs-Original-Cc: "Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors" , jm@pub.pink, 68690@debbugs.gnu.org, Eli Zaretskii Original-Received: via spool by submit@debbugs.gnu.org id=B.170627695014642 (code B ref -1); Fri, 26 Jan 2024 13:50:01 +0000 Original-Received: (at submit) by debbugs.gnu.org; 26 Jan 2024 13:49:10 +0000 Original-Received: from localhost ([127.0.0.1]:50678 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTMZy-0003o4-Bb for submit@debbugs.gnu.org; Fri, 26 Jan 2024 08:49:10 -0500 Original-Received: from lists.gnu.org ([2001:470:142::17]:43884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rTMZw-0003nS-Bb for submit@debbugs.gnu.org; Fri, 26 Jan 2024 08:49:08 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTMZj-0008GH-KR for bug-gnu-emacs@gnu.org; Fri, 26 Jan 2024 08:48:55 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rTMZh-00049U-To; Fri, 26 Jan 2024 08:48:55 -0500 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 6726A442222; Fri, 26 Jan 2024 08:48:50 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1706276928; bh=QAdoufoVUsQMEZlr1SXgUM2rw7xDwoWGaSNHjFSIz3I=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=JeUlGm056/1kJDDSmZW8luoqSg839DeCaD30oARhQlcbn7I+84FpC+RRAa+CvCyxj ybsV2cjmMxWyRJn+3l8mA+GWqLhz5WXjDb9AuFdWqa+VcclX/Sgf0JEdfuFP7jmKVx I3dRMqIa6rKTzVcoojrT0ubSjK8wiFuWta+ED2Bw3u0twS/vX5kndC41qp7lprZ/GY ltaVM+Se9gQVCDa8Qc7b8UGeHSXncQ/n4JrL7ErBVa6bQNku6oK+p1e6f3JpkZWcTh T/RZTDmLF/AHeyKpMU1ae3NhXWP4Q4HmHEyYUykzuUA+vJN0A9o0BKo/4tNkstzWEo qjWt2T3+MuCtQ== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id DCE0944222D; Fri, 26 Jan 2024 08:48:48 -0500 (EST) Original-Received: from pastel (unknown [45.72.206.68]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id A776E12022D; Fri, 26 Jan 2024 08:48:48 -0500 (EST) In-Reply-To: ("Gerd =?UTF-8?Q?M=C3=B6llmann?="'s message of "Fri, 26 Jan 2024 10:26:00 +0100") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.bugs:278925 Archived-At: --=-=-= Content-Type: text/plain > I remembered seeing something in pdumper.c that could be related, namely > > /* Start the cold section. This section contains bytes that should > never change and so can be direct-mapped from the dump without > special processing. */ > dump_drain_cold_data (ctx); > > And if you follow that function you'll see that it treats charsets > specially. > > I find the comment about directly mapping very suspicious, when the > charset contains a Lisp_Object, possibly requiring relocation. But it > could well be that I misundertand something here. Hmm... would a patch like the one below fix the problem, then? Stefan --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=cold-charset.patch diff --git a/src/pdumper.c b/src/pdumper.c index f42d1777371..56177d3fd89 100644 --- a/src/pdumper.c +++ b/src/pdumper.c @@ -440,7 +440,6 @@ dump_fingerprint (FILE *output, char const *label, { COLD_OP_OBJECT, COLD_OP_STRING, - COLD_OP_CHARSET, COLD_OP_BUFFER, COLD_OP_BIGNUM, COLD_OP_NATIVE_SUBR, @@ -3245,10 +3244,6 @@ dump_charset (struct dump_context *ctx, int cs_i) memcpy (out.fast_map, &cs->fast_map, sizeof (cs->fast_map)); DUMP_FIELD_COPY (&out, cs, code_offset); dump_off offset = dump_object_finish (ctx, &out, sizeof (out)); - if (cs_i < charset_table_used && cs->code_space_mask) - dump_remember_cold_op (ctx, COLD_OP_CHARSET, - Fcons (dump_off_to_lisp (cs_i), - dump_off_to_lisp (offset))); return offset; } @@ -3402,20 +3397,6 @@ dump_cold_string (struct dump_context *ctx, Lisp_Object string) dump_write (ctx, XSTRING (string)->u.s.data, total_size); } -static void -dump_cold_charset (struct dump_context *ctx, Lisp_Object data) -{ - /* Dump charset lookup tables. */ - int cs_i = XFIXNUM (XCAR (data)); - dump_off cs_dump_offset = dump_off_from_lisp (XCDR (data)); - dump_remember_fixup_ptr_raw - (ctx, - cs_dump_offset + dump_offsetof (struct charset, code_space_mask), - ctx->offset); - struct charset *cs = charset_table + cs_i; - dump_write (ctx, cs->code_space_mask, 256); -} - static void dump_cold_buffer (struct dump_context *ctx, Lisp_Object data) { @@ -3509,9 +3490,6 @@ dump_drain_cold_data (struct dump_context *ctx) case COLD_OP_STRING: dump_cold_string (ctx, data); break; - case COLD_OP_CHARSET: - dump_cold_charset (ctx, data); - break; case COLD_OP_BUFFER: dump_cold_buffer (ctx, data); break; --=-=-=--