From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [elpa] externals/hyperbole 4314e8c246: Get list of args from closures (#528) Date: Sat, 18 May 2024 19:19:24 -0400 Message-ID: References: <171607308439.16669.4136339982286918361@vcs2.savannah.gnu.org> <20240518225804.DB081C35346@vcs2.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="15134"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: emacs-devel@gnu.org To: Mats Lidell Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun May 19 01:20:29 2024 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1s8TLn-0003fL-Jh for ged-emacs-devel@m.gmane-mx.org; Sun, 19 May 2024 01:20:27 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1s8TKv-0004Bb-82; Sat, 18 May 2024 19:19:33 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8TKt-0004BM-Ni for emacs-devel@gnu.org; Sat, 18 May 2024 19:19:31 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1s8TKs-000518-4L for emacs-devel@gnu.org; Sat, 18 May 2024 19:19:31 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id EF8FD80251; Sat, 18 May 2024 19:19:27 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1716074366; bh=wxBN4V3zEDgUolWnbhab974vPL3/f+EGOHAwYMqPi1Y=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=lhQAcEBOviVnT1oH/QaJGUPbQvjsJ6X0+EDjPP+xHGyLW4rAZ0HRpiEHjis3Y81G4 A9YBD2u3omJ0mY7i372MZqRl1cFFZKdsVdx98lrW2aWc51H49VOWFUMbUUAMXNotKH YHGzARc5uGT3Lhz9IYEJ1gEKUYV8yLCusNtC2n4ta9tfZex6FtjjVM1z5peVtvG9r7 7UU/XB00JuRWWadUXgAMsQ7uhHRjQq/xWpHcdj6x6jpbDsFvD0iV/2n4GgYFdzJmdC PO8b89MXqr0peylOY9LXWEr918aNHBDr3UBzTxv0I7Cqrglb3gB2q8hyU1D5lsgoaE UvoINRnPAgO+A== Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id CB41E800E1; Sat, 18 May 2024 19:19:26 -0400 (EDT) Original-Received: from pastel (unknown [45.72.201.215]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 63C8A12047E; Sat, 18 May 2024 19:19:26 -0400 (EDT) In-Reply-To: <20240518225804.DB081C35346@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Sat, 18 May 2024 18:58:04 -0400 (EDT)") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.emacs.devel:319357 Archived-At: > @@ -100,7 +100,8 @@ Current button is being edited when EDITING-FLAG is t. > Return nil if ACTION is not a list or `byte-code' object, has no > interactive form or takes no arguments." > (save-excursion > - (and (or (subrp action) (byte-code-function-p action) (listp action)) > + (and (or (subrp action) (byte-code-function-p action) (listp action) > + (and (fboundp #'closurep) (closurep action))) > (let ((interactive-form (action:commandp action))) > (when interactive-form > (hpath:relative-arguments Why not remove this `(or ...)` altogether, and just call `interactive-form` and see if it returns non-nil? Stefan