* Re: [elpa] externals/hyperbole 4314e8c246: Get list of args from closures (#528)
[not found] ` <20240518225804.DB081C35346@vcs2.savannah.gnu.org>
@ 2024-05-18 23:19 ` Stefan Monnier
2024-05-19 7:22 ` Mats Lidell
0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2024-05-18 23:19 UTC (permalink / raw)
To: Mats Lidell; +Cc: emacs-devel
> @@ -100,7 +100,8 @@ Current button is being edited when EDITING-FLAG is t.
> Return nil if ACTION is not a list or `byte-code' object, has no
> interactive form or takes no arguments."
> (save-excursion
> - (and (or (subrp action) (byte-code-function-p action) (listp action))
> + (and (or (subrp action) (byte-code-function-p action) (listp action)
> + (and (fboundp #'closurep) (closurep action)))
> (let ((interactive-form (action:commandp action)))
> (when interactive-form
> (hpath:relative-arguments
Why not remove this `(or ...)` altogether, and just call `interactive-form`
and see if it returns non-nil?
Stefan
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [elpa] externals/hyperbole 4314e8c246: Get list of args from closures (#528)
2024-05-18 23:19 ` [elpa] externals/hyperbole 4314e8c246: Get list of args from closures (#528) Stefan Monnier
@ 2024-05-19 7:22 ` Mats Lidell
0 siblings, 0 replies; 2+ messages in thread
From: Mats Lidell @ 2024-05-19 7:22 UTC (permalink / raw)
To: Stefan Monnier; +Cc: emacs-devel, Robert Weiner
Hi Stefan,
> Stefan Monnier writes:
> Why not remove this `(or ...)` altogether, and just call `interactive-form`
> and see if it returns non-nil?
Yes, why not! ;-)
Thanks for the suggestion.
%% Mats
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-05-19 7:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <171607308439.16669.4136339982286918361@vcs2.savannah.gnu.org>
[not found] ` <20240518225804.DB081C35346@vcs2.savannah.gnu.org>
2024-05-18 23:19 ` [elpa] externals/hyperbole 4314e8c246: Get list of args from closures (#528) Stefan Monnier
2024-05-19 7:22 ` Mats Lidell
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.