From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Mats Lidell <mats.lidell@lidells.se>
Cc: emacs-devel@gnu.org
Subject: Re: [elpa] externals/hyperbole 4314e8c246: Get list of args from closures (#528)
Date: Sat, 18 May 2024 19:19:24 -0400 [thread overview]
Message-ID: <jwv7cfqlngx.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20240518225804.DB081C35346@vcs2.savannah.gnu.org> (ELPA Syncer's message of "Sat, 18 May 2024 18:58:04 -0400 (EDT)")
> @@ -100,7 +100,8 @@ Current button is being edited when EDITING-FLAG is t.
> Return nil if ACTION is not a list or `byte-code' object, has no
> interactive form or takes no arguments."
> (save-excursion
> - (and (or (subrp action) (byte-code-function-p action) (listp action))
> + (and (or (subrp action) (byte-code-function-p action) (listp action)
> + (and (fboundp #'closurep) (closurep action)))
> (let ((interactive-form (action:commandp action)))
> (when interactive-form
> (hpath:relative-arguments
Why not remove this `(or ...)` altogether, and just call `interactive-form`
and see if it returns non-nil?
Stefan
next parent reply other threads:[~2024-05-18 23:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <171607308439.16669.4136339982286918361@vcs2.savannah.gnu.org>
[not found] ` <20240518225804.DB081C35346@vcs2.savannah.gnu.org>
2024-05-18 23:19 ` Stefan Monnier [this message]
2024-05-19 7:22 ` [elpa] externals/hyperbole 4314e8c246: Get list of args from closures (#528) Mats Lidell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv7cfqlngx.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=mats.lidell@lidells.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.