From: Stefan Monnier <monnier@iro.umontreal.ca>
Cc: Juanma Barranquero <lekktu@gmail.com>,
Eli Zaretskii <eliz@gnu.org>,
snogglethorpe@gmail.com, emacs-devel@gnu.org, miles@gnu.org
Subject: Re: What holds the release
Date: Wed, 15 Jun 2005 12:21:43 -0400 [thread overview]
Message-ID: <jwv64wfmxvw.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <3158.220.255.175.166.1118847958.squirrel@www.stupidchicken.com> (Chong Yidong's message of "Wed, 15 Jun 2005 11:05:58 -0400 (EDT)")
>> Make VC-over-Tramp work where possible, or at least fail
>> gracefully if something isn't supported over Tramp.
>> To be done by Andre Spiegel <spiegel@gnu.org>.
> This has been sitting there for several months now. Has it already been
> done? Is it a major inconvenience worth delaying 22.1 for?
I'd happily drop it.
>> define-minor-mode should not put :require into defcustom.
>> See msg from rms to emacs-devel on 21 Dec.
> The relevant URL is
> http://lists.gnu.org/archive/html/emacs-devel/2004-12/msg00732.html
> I've tried working on this, with no result. I couldn't find a clean way
> to implement RMS's suggestion, and I'm not sure it even makes sense. A
> workaround for the particular problem originally reported by Stephen Stahl
> is to add (require 'font-lock) to font-core.el and a ":require 'font-lock"
> tag to the definition of global-font-lock-mode. Maybe we should just do
> that, and wait for 22.2 for whatever general solution is required. (It
> would be *nice* to get it into 22.1, but what it would *not* be nice to
> delay 22.1 into 2006 just for that.)
Looking at it some more, here is my thoughts about it:
- this problem is only relevant for global minor modes (buffer-local minor
modes can't be enabled/disabled via custom).
- every global minor mode is either pre-loaded or autoloaded.
So we should simply never add thje :require directive and we just need to
make sure that the :setter info (custom-set-minor-mode) is included in
loaddefs.el for the autoloaded vars so that enabling/disabling will go
through the minor mode function and trigger the autoloading.
I.e. the sample patch below seems to fix the problem.
>> ** Update Speedbar.
> The relevant URL is
> http://lists.gnu.org/archive/html/emacs-devel/2005-05/msg00180.html
> It sounds like this will be fixed soon.
Hopefully, yes.
>> Enhance scroll-bar to handle tall line (similar to line-move).
> This is a feature request, not a show-stopping bug. In the real world,
> 99.9% of users don't use Emacs as an image viewer; they use a specialized
> image viewing program. Emacs is currently a mediocre image viewer; it
> would be nice if it were a great image viewer, but not essential for the
> release.
100% agreement.
>> Adapt mouse-sel-mode to mouse-1-click-follows-link.
> I fixed this a couple weeks ago. This entry should be removed.
Done, thanks.
>> Make GTK scrollbars behave like others w.r.t. overscrolling.
> I don't experience any problem with GTK scrollbars. It does not seem to
> be a show-stopper.
Agreed.
>> Avoid unbreakable loops in redisplay.
> This is an "it would be nice" feature, not a show-stopper. It would be
> nice to have a safety feature to avoid running inappropriate display
> properties, but AFAIK people aren't actually being affected by such bugs.
> This shouldn't block the release.
Agreed.
Stefan
Index: lisp/emacs-lisp/easy-mmode.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/easy-mmode.el,v
retrieving revision 1.65
diff -u -r1.65 easy-mmode.el
--- lisp/emacs-lisp/easy-mmode.el 8 Jun 2005 15:54:43 -0000 1.65
+++ lisp/emacs-lisp/easy-mmode.el 15 Jun 2005 16:18:23 -0000
@@ -201,10 +201,7 @@
:type 'boolean
,@(cond
((not (and curfile require)) nil)
- ((not (eq require t)) `(:require ,require))
- (t `(:require
- ',(intern (file-name-nondirectory
- (file-name-sans-extension curfile))))))
+ ((not (eq require t)) `(:require ,require)))
,@(nreverse extra-keywords))))
;; The actual function.
Index: lisp/emacs-lisp/autoload.el
===================================================================
RCS file: /cvsroot/emacs/emacs/lisp/emacs-lisp/autoload.el,v
retrieving revision 1.104
diff -u -r1.104 autoload.el
--- lisp/emacs-lisp/autoload.el 31 Mar 2005 21:17:40 -0000 1.104
+++ lisp/emacs-lisp/autoload.el 15 Jun 2005 16:18:23 -0000
@@ -1,7 +1,7 @@
;; autoload.el --- maintain autoloads in loaddefs.el
-;; Copyright (C) 1991,92,93,94,95,96,97, 2001,02,03,04
-;; Free Software Foundation, Inc.
+;; Copyright (C) 1991, 1992, 1993, 1994, 1995, 1996, 1997, 2001, 2002, 2003,
+;; 2004, 2005 Free Software Foundation, Inc.
;; Author: Roland McGrath <roland@gnu.org>
;; Keywords: maint
@@ -123,7 +123,17 @@
)
`(progn
(defvar ,varname ,init ,doc)
- (custom-autoload ',varname ,file))))
+ (custom-autoload ',varname ,file)
+ ;; The use of :require in a defcustom can be annoying, especially
+ ;; when defcustoms are moved from one file to another between
+ ;; releases because the :require arg gets placed in the user's
+ ;; .emacs. In order for autoloaded minor modes not to need the
+ ;; use of :require, we arrange to store their :setter.
+ ,(let ((setter (condition-case nil
+ (cadr (memq :set form))
+ (error nil))))
+ (if (equal setter ''custom-set-minor-mode)
+ `(put ',varname 'custom-set 'custom-set-minor-mode))))))
;; nil here indicates that this is not a special autoload form.
(t nil))))
@@ -566,5 +576,5 @@
(provide 'autoload)
-;;; arch-tag: 00244766-98f4-4767-bf42-8a22103441c6
+;; arch-tag: 00244766-98f4-4767-bf42-8a22103441c6
;;; autoload.el ends here
next prev parent reply other threads:[~2005-06-15 16:21 UTC|newest]
Thread overview: 113+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-06-10 23:21 mouse-1-click-follows-link Nick Roberts
2005-06-11 1:56 ` mouse-1-click-follows-link Daniel Brockman
2005-06-11 9:55 ` mouse-1-click-follows-link Nick Roberts
2005-06-11 16:21 ` mouse-1-click-follows-link Daniel Brockman
2005-06-12 7:51 ` mouse-1-click-follows-link Nick Roberts
2005-06-12 19:57 ` mouse-1-click-follows-link Richard Stallman
2005-06-13 16:19 ` mouse-1-click-follows-link Drew Adams
2005-06-13 18:51 ` mouse-1-click-follows-link Jason Rumney
2005-06-13 20:15 ` mouse-1-click-follows-link Drew Adams
2005-06-13 20:49 ` mouse-1-click-follows-link Jason Rumney
2005-06-13 21:50 ` mouse-1-click-follows-link David Kastrup
2005-06-13 22:07 ` mouse-1-click-follows-link Jason Rumney
2005-06-13 22:18 ` mouse-1-click-follows-link David Kastrup
2005-06-14 2:03 ` mouse-1-click-follows-link Miles Bader
2005-06-14 5:53 ` mouse-1-click-follows-link Lennart Borgman
2005-06-14 7:03 ` mouse-1-click-follows-link Jason Rumney
2005-06-14 20:06 ` mouse-1-click-follows-link Lennart Borgman
2005-06-13 22:28 ` mouse-1-click-follows-link Juanma Barranquero
2005-06-14 8:02 ` mouse-1-click-follows-link Nick Roberts
2005-06-14 8:37 ` mouse-1-click-follows-link Juanma Barranquero
2005-06-14 12:29 ` mouse-1-click-follows-link Mathias Dahl
2005-06-14 12:43 ` mouse-1-click-follows-link David Kastrup
2005-06-14 12:54 ` mouse-1-click-follows-link Mathias Dahl
2005-06-14 13:21 ` mouse-1-click-follows-link Juanma Barranquero
2005-06-14 13:14 ` mouse-1-click-follows-link Juanma Barranquero
2005-06-14 21:58 ` What holds the release (was: mouse-1-click-follows-link) Eli Zaretskii
2005-06-14 22:54 ` Juanma Barranquero
2005-06-15 2:13 ` John S. Yates, Jr.
2005-06-15 3:37 ` Eli Zaretskii
2005-06-15 7:29 ` Juanma Barranquero
2005-06-15 13:06 ` What holds the release Mathias Dahl
2005-06-15 3:12 ` What holds the release (was: mouse-1-click-follows-link) Miles Bader
2005-06-15 7:36 ` Juanma Barranquero
2005-06-15 8:05 ` Miles Bader
2005-06-15 8:23 ` Juanma Barranquero
2005-06-15 15:05 ` Chong Yidong
2005-06-15 16:21 ` Stefan Monnier [this message]
2005-06-20 3:50 ` What holds the release Richard Stallman
2005-06-16 16:24 ` What holds the release (was: mouse-1-click-follows-link) Richard Stallman
2005-06-20 3:50 ` Richard Stallman
2005-06-16 4:07 ` Richard Stallman
2005-06-16 7:51 ` Juanma Barranquero
2005-06-15 3:35 ` Eli Zaretskii
2005-06-15 7:40 ` Juanma Barranquero
2005-06-15 18:37 ` Eli Zaretskii
2005-06-15 17:49 ` Juanma Barranquero
2005-06-16 4:08 ` Richard Stallman
2005-06-16 8:09 ` Juanma Barranquero
2005-06-16 10:48 ` What holds the release David Kastrup
2005-06-16 12:39 ` Juanma Barranquero
2005-06-16 15:22 ` Thien-Thi Nguyen
2005-06-16 19:43 ` What holds the release (was: mouse-1-click-follows-link) Eli Zaretskii
2005-06-16 21:08 ` Juanma Barranquero
2005-06-17 4:38 ` Richard Stallman
2005-06-14 21:48 ` mouse-1-click-follows-link Eli Zaretskii
2005-06-14 22:20 ` mouse-1-click-follows-link Juanma Barranquero
2005-06-13 22:47 ` mouse-1-click-follows-link Stefan Monnier
2005-06-13 23:29 ` mouse-1-click-follows-link Drew Adams
2005-06-14 1:26 ` mouse-1-click-follows-link Daniel Brockman
2005-06-14 14:04 ` mouse-1-click-follows-link Stefan Monnier
2005-06-14 2:25 ` mouse-1-click-follows-link David Abrahams
2005-06-14 6:00 ` mouse-1-click-follows-link Lennart Borgman
2005-06-14 18:08 ` mouse-1-click-follows-link Drew Adams
2005-06-14 20:25 ` mouse-1-click-follows-link Stefan Monnier
2005-06-14 20:42 ` mouse-1-click-follows-link Drew Adams
2005-06-15 16:26 ` mouse-1-click-follows-link Drew Adams
2005-06-15 20:34 ` mouse-1-click-follows-link Daniel Brockman
2005-06-16 4:08 ` mouse-1-click-follows-link Richard Stallman
2005-06-14 7:28 ` mouse-1-click-follows-link Kim F. Storm
2005-06-14 8:36 ` mouse-1-click-follows-link David Kastrup
2005-06-13 20:35 ` mouse-1-click-follows-link Jason Rumney
2005-06-14 7:27 ` mouse-1-click-follows-link Kim F. Storm
2005-06-14 11:32 ` mouse-1-click-follows-link Jason Rumney
2005-06-14 11:56 ` mouse-1-click-follows-link Kim F. Storm
2005-06-15 14:46 ` mouse-1-click-follows-link Richard Stallman
2005-06-15 14:56 ` mouse-1-click-follows-link Kim F. Storm
2005-06-15 15:07 ` mouse-1-click-follows-link Lennart Borgman
2005-06-15 16:26 ` mouse-1-click-follows-link Drew Adams
2005-06-16 16:24 ` mouse-1-click-follows-link Richard Stallman
2005-06-15 16:45 ` mouse-1-click-follows-link Jason Rumney
2005-06-17 12:17 ` mouse-1-click-follows-link Juri Linkov
2005-06-17 13:08 ` mouse-1-click-follows-link Jason Rumney
2005-06-17 18:46 ` mouse-1-click-follows-link Richard Stallman
2005-06-17 22:26 ` mouse-1-click-follows-link Jason Rumney
2005-06-18 11:11 ` mouse-1-click-follows-link Robert J. Chassell
2005-06-18 13:54 ` mouse-1-click-follows-link Juri Linkov
2005-06-17 13:34 ` mouse-1-click-follows-link Nick Roberts
2005-06-17 18:46 ` mouse-1-click-follows-link Richard Stallman
2005-06-18 13:54 ` mouse-1-click-follows-link Juri Linkov
2005-06-19 3:51 ` mouse-1-click-follows-link Richard Stallman
2005-06-19 13:03 ` mouse-1-click-follows-link Juri Linkov
2005-06-20 3:50 ` mouse-1-click-follows-link Richard Stallman
2005-06-17 12:04 ` mouse-1-click-follows-link Juri Linkov
2005-06-17 18:46 ` mouse-1-click-follows-link Richard Stallman
2005-06-14 2:02 ` mouse-1-click-follows-link Miles Bader
2005-06-14 13:35 ` mouse-1-click-follows-link Robert J. Chassell
2005-06-14 15:00 ` mouse-1-click-follows-link Daniel Brockman
2005-06-14 19:26 ` mouse-1-click-follows-link Robert J. Chassell
2005-06-15 14:46 ` mouse-1-click-follows-link Richard Stallman
2005-06-15 17:27 ` mouse-1-click-follows-link David Abrahams
2005-06-15 18:56 ` mouse-1-click-follows-link David Kastrup
2005-06-15 19:06 ` mouse-1-click-follows-link David Abrahams
2005-06-16 16:23 ` mouse-1-click-follows-link Richard Stallman
2005-06-15 14:46 ` mouse-1-click-follows-link Richard Stallman
2005-06-14 19:29 ` mouse-1-click-follows-link Lennart Borgman
2005-06-13 22:19 ` mouse-1-click-follows-link Nick Roberts
2005-06-13 23:07 ` mouse-1-click-follows-link David Kastrup
2005-06-13 23:30 ` mouse-1-click-follows-link Drew Adams
2005-06-11 23:16 ` mouse-1-click-follows-link Richard Stallman
2005-06-12 7:56 ` mouse-1-click-follows-link Nick Roberts
2005-06-12 19:57 ` mouse-1-click-follows-link Richard Stallman
2005-06-13 6:06 ` mouse-1-click-follows-link Juri Linkov
2005-06-11 23:16 ` mouse-1-click-follows-link Richard Stallman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv64wfmxvw.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=eliz@gnu.org \
--cc=emacs-devel@gnu.org \
--cc=lekktu@gmail.com \
--cc=miles@gnu.org \
--cc=snogglethorpe@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.