Xaw3d configure fix

Xaw3d configure fix

[Emanuele Giaquinta]

[-- Attachment #1: Type: text/plain, Size: 464 bytes --]

Hi,

The attached pach to configure.in disables the Xaw3d check when
--without-toolkit-scroll-bars is specified, to link emacs to libXaw
instead of libXaw3d when both are installed; I am assuming the only
reason to prefer Xaw3d to Xaw is for scroll-bars.
BTW, xterm.c seems to support Xaw scroll-bars, but they are never
enabled because USE_TOOLKIT_SCROLL_BARS is defined only when MOTIF or
Xaw3d is available wrt USE_X_TOOLKIT.

--
Emanuele Giaquinta

[-- Attachment #2: configure-xaw3d.patch --]
[-- Type: application/octet-stream, Size: 694 bytes --]

Index: configure.in
===================================================================
RCS file: /sources/emacs/emacs/configure.in,v
retrieving revision 1.406
diff -u -r1.406 configure.in
--- configure.in	14 Feb 2006 15:32:49 -0000	1.406
+++ configure.in	29 Mar 2006 12:45:48 -0000
@@ -2179,7 +2179,7 @@
 ### Is -lXaw3d available?
 HAVE_XAW3D=no
 if test "${HAVE_X11}" = "yes"; then
-  if test "${USE_X_TOOLKIT}" != "none"; then
+  if test "${USE_X_TOOLKIT}" != "none" && test "${with_toolkit_scroll_bars}" != "no"; then
     dnl Fixme: determine what Scrollbar.h needs to avoid compilation
     dnl errors from the test without the `-'.
     AC_CHECK_HEADER(X11/Xaw3d/Scrollbar.h,












[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Emacs-devel mailing list
Emacs-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/emacs-devel

Re: Xaw3d configure fix

[Stefan Monnier]

> BTW, xterm.c seems to support Xaw scroll-bars, but they are never
> enabled because USE_TOOLKIT_SCROLL_BARS is defined only when MOTIF or
> Xaw3d is available wrt USE_X_TOOLKIT.

Indeed, when I hacked on the scrollbar code, I tried to make sure it works
with Xaw as well as a matter of good principle.  But nobody has considered
it worthwhile to provide yet-another compilation option.  I think there'd be
more interest in making it possible to use the non-toolkit-scrollbars even
if you compiled with toolkit scrollbars (i.e. make the choice at run time,
maybe even on a window-by-window basis).


        Stefan

Re: Xaw3d configure fix

[Richard Stallman]

    > BTW, xterm.c seems to support Xaw scroll-bars, but they are never
    > enabled because USE_TOOLKIT_SCROLL_BARS is defined only when MOTIF or
    > Xaw3d is available wrt USE_X_TOOLKIT.

    Indeed, when I hacked on the scrollbar code, I tried to make sure it works
    with Xaw as well as a matter of good principle.  But nobody has considered
    it worthwhile to provide yet-another compilation option.

The proposal is to use Xaw scroll bars.  That need not be a
compilation option--it could be done unconditionally when using Xt and
Xaw.

Whether that would be an improvement, I don't know.

I don't know whether it has any advantages.

Re: Xaw3d configure fix

[Richard Stallman]

    BTW, xterm.c seems to support Xaw scroll-bars, but they are never
    enabled because USE_TOOLKIT_SCROLL_BARS is defined only when MOTIF or
    Xaw3d is available wrt USE_X_TOOLKIT.

Now seems like the wrong time to change that, but could you send a patch
after the next release?

Re: Xaw3d configure fix

[Emanuele Giaquinta]

> Now seems like the wrong time to change that, but could you send a patch
> after the next release?

Yes, but my patch was about another issue; when
'--without-toolkit-scroll-bars' is specified emacs will be linked to
Xaw, if Xaw3d is not installed, to the latter otherwise. This seems to
me inconsistent and I was proposing to always link to Xaw in that
case.

--
Emanuele Giaquinta

Re: Xaw3d configure fix

[Richard Stallman]

    Yes, but my patch was about another issue; when
    '--without-toolkit-scroll-bars' is specified emacs will be linked to
    Xaw, if Xaw3d is not installed, to the latter otherwise. This seems to
    me inconsistent and I was proposing to always link to Xaw in that
    case.

Sorry, I do not understand.