From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Miles Bader <miles@gnu.org>
Cc: Diane Murray <disumu@x3y2z1.net>, emacs-devel@gnu.org
Subject: Re: Fix previous-button to work with connected buttons
Date: Sun, 11 Mar 2007 17:46:19 -0400 [thread overview]
Message-ID: <jwv6497h2xg.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87tzws5mx0.fsf@catnip.gol.com> (Miles Bader's message of "Sun\, 11 Mar 2007 15\:12\:11 +0900")
>> How 'bout the patch below, then?
>> + (add-text-properties beg end
>> + ;; Each button should have a different `button'
>> + ;; property so that next-single-property-change can
>> + ;; detect boundaries reliably.
>> + (cons 'button (cons (list t) properties)))
> Hmm. Any reason to waste a cons-cell?
Because it's simpler and 100% reliable, and the waste is negligible (think
of the amount of consing needed for the total list of properties, plus the
amount of consing needed for the data-structure that keeps track of the
text-properties, ...).
> I imagine something like
> (cons 'button (cons (setq button-counter (1+ button-counter)) properties))
> would work as well.
Sure. Except for wraparounds, of course. Not that they're likely.
Stefan
next prev parent reply other threads:[~2007-03-11 21:46 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-10 23:53 Fix previous-button to work with connected buttons Diane Murray
2007-03-11 2:08 ` Stefan Monnier
2007-03-11 2:45 ` Miles Bader
2007-03-11 6:00 ` Stefan Monnier
2007-03-11 6:12 ` Miles Bader
2007-03-11 10:55 ` David Kastrup
2007-03-11 12:53 ` Miles Bader
2007-03-11 13:04 ` David Kastrup
2007-03-11 21:46 ` Stefan Monnier [this message]
2007-03-11 22:52 ` Miles Bader
2007-04-01 2:28 ` Diane Murray
2007-04-01 14:00 ` Richard Stallman
2007-04-01 17:15 ` Chong Yidong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv6497h2xg.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=disumu@x3y2z1.net \
--cc=emacs-devel@gnu.org \
--cc=miles@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.