From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: vera-mode.el Date: Wed, 06 Jun 2007 14:03:01 -0400 Message-ID: References: <4665C2DC.3090102@synopsys.com> <4666EB5D.7040909@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1181153014 26418 80.91.229.12 (6 Jun 2007 18:03:34 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Wed, 6 Jun 2007 18:03:34 +0000 (UTC) Cc: emacs-devel@gnu.org To: Reto Zimmermann Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Jun 06 20:03:32 2007 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1Hvzqy-0006Gi-5x for ged-emacs-devel@m.gmane.org; Wed, 06 Jun 2007 20:03:28 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hvzqx-0000xd-Qk for ged-emacs-devel@m.gmane.org; Wed, 06 Jun 2007 14:03:27 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Hvzqf-0000oT-Og for emacs-devel@gnu.org; Wed, 06 Jun 2007 14:03:09 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Hvzqe-0000mt-Kw for emacs-devel@gnu.org; Wed, 06 Jun 2007 14:03:09 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Hvzqe-0000mj-EJ for emacs-devel@gnu.org; Wed, 06 Jun 2007 14:03:08 -0400 Original-Received: from mercure.iro.umontreal.ca ([132.204.24.67]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Hvzqc-0004Yt-QC; Wed, 06 Jun 2007 14:03:07 -0400 Original-Received: from hidalgo.iro.umontreal.ca (hidalgo.iro.umontreal.ca [132.204.27.50]) by mercure.iro.umontreal.ca (Postfix) with ESMTP id DB4A22CE9BE; Wed, 6 Jun 2007 14:03:05 -0400 (EDT) Original-Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by hidalgo.iro.umontreal.ca (Postfix) with ESMTP id F26BF3FE0; Wed, 6 Jun 2007 14:03:01 -0400 (EDT) Original-Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id DC3E96C812; Wed, 6 Jun 2007 14:03:01 -0400 (EDT) In-Reply-To: <4666EB5D.7040909@gnu.org> (Reto Zimmermann's message of "Wed\, 06 Jun 2007 19\:14\:05 +0200") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1.50 (gnu/linux) X-DIRO-MailScanner-Information: Please contact the ISP for more information X-DIRO-MailScanner: Found to be clean X-DIRO-MailScanner-SpamCheck: n'est pas un polluriel, SpamAssassin (score=-2.82, requis 5, autolearn=not spam, ALL_TRUSTED -2.82) X-DIRO-MailScanner-From: monnier@iro.umontreal.ca X-detected-kernel: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:72358 Archived-At: > Attached is the latest version of the new vera-mode.el for review and > addition to the Emacs distribution. - What's end-comment-column? Sounds like comment-fill-column. - It seems the language allows both //...\n and /*...*/ for comments, but the comment-start-skip does not reflect that. And it should also define the corresponding comment-end-skip. - Also it should not (require 'font-lock) and neither should it call (turn-on-font-lock). - The call to easy-menu-define should be at toplevel rather than inside vera-mode. And then the call to easy-menu-add should refer to vera-mode-menu rather than vera-mode-menu-list (which could be inlined into the call to easy-menu-define and then removed). - The calls to modify-syntax-entry should not be at toplevel and neither should the (setq vera-mode-syntax-table (make-syntax-table)). Best is to move it all inside the "defvar vera-mode-syntax-table" in the usual form (defvar vera-mode-syntax-table (let ((st (make-syntax-table))) ... st)). -- Stefan