From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Reto Zimmermann <reto@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: vera-mode.el
Date: Wed, 06 Jun 2007 14:03:01 -0400 [thread overview]
Message-ID: <jwv6461c6pq.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4666EB5D.7040909@gnu.org> (Reto Zimmermann's message of "Wed\, 06 Jun 2007 19\:14\:05 +0200")
> Attached is the latest version of the new vera-mode.el for review and
> addition to the Emacs distribution.
- What's end-comment-column? Sounds like comment-fill-column.
- It seems the language allows both //...\n and /*...*/ for comments, but the
comment-start-skip does not reflect that. And it should also define the
corresponding comment-end-skip.
- Also it should not (require 'font-lock) and neither should it call
(turn-on-font-lock).
- The call to easy-menu-define should be at toplevel rather than inside
vera-mode. And then the call to easy-menu-add should refer to
vera-mode-menu rather than vera-mode-menu-list (which could be inlined
into the call to easy-menu-define and then removed).
- The calls to modify-syntax-entry should not be at toplevel and neither
should the (setq vera-mode-syntax-table (make-syntax-table)). Best is to
move it all inside the "defvar vera-mode-syntax-table" in the usual form
(defvar vera-mode-syntax-table (let ((st (make-syntax-table))) ... st)).
-- Stefan
next prev parent reply other threads:[~2007-06-06 18:03 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1HveXE-00080m-T4@fencepost.gnu.org>
[not found] ` <4665C2DC.3090102@synopsys.com>
[not found] ` <E1HvyqV-0003IZ-Fj@fencepost.gnu.org>
2007-06-06 17:14 ` vera-mode.el Reto Zimmermann
2007-06-06 18:03 ` Stefan Monnier [this message]
2007-06-06 21:30 ` vera-mode.el Reto Zimmermann
2007-06-06 23:38 ` vera-mode.el Dan Nicolaescu
2007-06-07 12:07 ` vera-mode.el Reto Zimmermann
2007-06-10 16:08 ` vera-mode.el Dan Nicolaescu
2007-06-11 10:52 ` vera-mode.el Reto Zimmermann
2007-06-11 11:22 ` vera-mode.el Miles Bader
2007-06-20 6:35 ` vera-mode.el Dan Nicolaescu
2007-06-20 8:22 ` vera-mode.el Reto Zimmermann
2007-06-20 7:24 ` vera-mode.el Glenn Morris
2007-06-20 8:51 ` vera-mode.el Reto Zimmermann
2007-06-07 12:35 ` vera-mode.el Stefan Monnier
2007-06-07 13:56 ` vera-mode.el Reto Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv6461c6pq.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=reto@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.