Calendar window height bug?

Calendar window height bug?

[Leo]

Hi all,

[GNU Emacs 23.0.0.4 (i686-pc-linux-gnu, GTK+ Version 2.10.14) of 2007-07-27]

The following change in calendar-basic-setup is problematic as now the
calendar window is not adjusted to fit the buffer.

--8<---------------cut here---------------start------------->8---
--- 1.el	2007-07-27 20:42:18.970945486 +0100
+++ 2.el	2007-07-27 20:42:51.965911897 +0100
@@ -53,9 +53,11 @@
     ;; (calendar-read-date t) returns a date with day = nil, which is
     ;; not a legal date for the visible test in the diary section.
     (if arg (setcar (cdr date) 1))
-    (pop-to-buffer calendar-buffer)
     (increment-calendar-month month year (- calendar-offset))
     (generate-calendar-window month year)
+    ;; Display the buffer *after* generating it, so that menu entries that
+    ;; use display-month do not fail when creating the new frame.
+    (pop-to-buffer calendar-buffer)
     (if (and view-diary-entries-initially (calendar-date-is-visible-p date))
         (diary-view-entries)))
   (let* ((diary-buffer (get-file-buffer diary-file))
--8<---------------cut here---------------end--------------->8---

HTH,
-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)

Re: Calendar window height bug?

[Stefan Monnier]

> Hi all,
> [GNU Emacs 23.0.0.4 (i686-pc-linux-gnu, GTK+ Version 2.10.14) of 2007-07-27]

> The following change in calendar-basic-setup is problematic as now the
> calendar window is not adjusted to fit the buffer.

I believe I've now fixed it in the trunk.


        Stefan

Re: Calendar window height bug?

[Leo]

On 2007-07-29 21:49 +0100, Stefan Monnier wrote:
>> Hi all,
>> [GNU Emacs 23.0.0.4 (i686-pc-linux-gnu, GTK+ Version 2.10.14) of 2007-07-27]
>
>> The following change in calendar-basic-setup is problematic as now the
>> calendar window is not adjusted to fit the buffer.
>
> I believe I've now fixed it in the trunk.
>
>
>         Stefan

Confirmed!

-- 
Leo <sdl.web AT gmail.com>                         (GPG Key: 9283AA3F)