From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Updated project-specific settings patch Date: Mon, 19 May 2008 20:04:57 -0400 Message-ID: References: <87ve19yl0p.fsf@grepfind.mwolson.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1211241959 9418 80.91.229.12 (20 May 2008 00:05:59 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 20 May 2008 00:05:59 +0000 (UTC) Cc: emacs-devel@gnu.org To: Michael Olson Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Tue May 20 02:06:35 2008 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JyFMl-0003zj-9e for ged-emacs-devel@m.gmane.org; Tue, 20 May 2008 02:06:07 +0200 Original-Received: from localhost ([127.0.0.1]:43134 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyFM0-000112-Oz for ged-emacs-devel@m.gmane.org; Mon, 19 May 2008 20:05:20 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JyFLv-00010l-GZ for emacs-devel@gnu.org; Mon, 19 May 2008 20:05:15 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JyFLt-00010Q-II for emacs-devel@gnu.org; Mon, 19 May 2008 20:05:15 -0400 Original-Received: from [199.232.76.173] (port=56612 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JyFLt-00010L-Bk for emacs-devel@gnu.org; Mon, 19 May 2008 20:05:13 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:39100) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JyFLp-0007l5-5t; Mon, 19 May 2008 20:05:09 -0400 Original-Received: from ceviche.home (vpn-132-204-232-83.acd.umontreal.ca [132.204.232.83]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id m4K056cj017771; Mon, 19 May 2008 20:05:06 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 89DBAB422F; Mon, 19 May 2008 20:04:59 -0400 (EDT) In-Reply-To: <87ve19yl0p.fsf@grepfind.mwolson.org> (Michael Olson's message of "Mon, 19 May 2008 15:41:26 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.0.60 (gnu/linux) X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3019=0 X-detected-kernel: by monty-python.gnu.org: Linux 2.6 (newer, 3) X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:97417 Archived-At: Stefan> In most cases, we'd prefer (expand-file-name Stefan> ".dir-settings.el" dir) over the use of `concat'. The only Stefan> exception I know is when `dir' is relative and it's important Stefan> for the result also be relative. >> >> No problem. >> >> New patch appended. > I've applied this patch. I modified it to go back to the old behavior > of using concat, however, because there were some objections to using > expand-file-name here, and I don't like calling expand-file-name where > it's not really needed. Please don't, it's the other way 'round: we should only use concat to build file names when expand-file-name is wrong. In doubt, use expand-file-name. Stefan