all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Michael Olson <mwolson@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Updated project-specific settings patch
Date: Mon, 19 May 2008 20:04:57 -0400	[thread overview]
Message-ID: <jwv63t9kfi4.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <87ve19yl0p.fsf@grepfind.mwolson.org> (Michael Olson's message of "Mon, 19 May 2008 15:41:26 -0700")

Stefan> In most cases, we'd prefer (expand-file-name
Stefan> ".dir-settings.el" dir) over the use of `concat'.  The only
Stefan> exception I know is when `dir' is relative and it's important
Stefan> for the result also be relative.
>> 
>> No problem.
>> 
>> New patch appended.

> I've applied this patch.  I modified it to go back to the old behavior
> of using concat, however, because there were some objections to using
> expand-file-name here, and I don't like calling expand-file-name where
> it's not really needed.

Please don't, it's the other way 'round: we should only use concat to
build file names when expand-file-name is wrong.  In doubt, use
expand-file-name.


        Stefan





  reply	other threads:[~2008-05-20  0:04 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-19 17:07 Updated project-specific settings patch Tom Tromey
2008-05-19 18:51 ` Stefan Monnier
2008-05-19 18:55   ` Miles Bader
2008-05-19 19:00     ` Tom Tromey
2008-05-20  2:35       ` Miles Bader
2008-05-19 19:23   ` Tom Tromey
2008-05-19 19:51     ` Re[2]: Project local variables & EDE (was: Updated project-specific settings patch) Eric M. Ludlam
2008-05-19 22:41     ` Updated project-specific settings patch Michael Olson
2008-05-20  0:04       ` Stefan Monnier [this message]
2008-05-20  3:18         ` Michael Olson
2008-05-20  0:14       ` Miles Bader
2008-05-20  7:19         ` David Kastrup
2008-05-19 20:29   ` David Kastrup
2008-05-19 21:57     ` Stefan Monnier
2008-05-19 19:32 ` joakim
2008-05-19 20:11   ` Re[2]: " Eric M. Ludlam
2008-05-20  3:27     ` Eli Zaretskii
2008-05-19 20:02 ` Chong Yidong
2008-05-19 21:55   ` Tom Tromey
2008-05-20 14:02     ` Chong Yidong
2008-05-20 18:45       ` Stefan Monnier
2008-05-21  0:04         ` Miles Bader
2008-05-21 19:49       ` Tom Tromey
2008-05-22  3:46         ` Chong Yidong
2008-05-23  6:31           ` Michael Olson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv63t9kfi4.fsf-monnier+emacs@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    --cc=mwolson@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.