From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: make vc-annotate work through copies and renames Date: Wed, 14 Oct 2009 23:10:49 -0400 Message-ID: References: <200910141558.n9EFwJVd023731@godzilla.ics.uci.edu> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1255576273 12458 80.91.229.12 (15 Oct 2009 03:11:13 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 15 Oct 2009 03:11:13 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dan Nicolaescu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Oct 15 05:11:03 2009 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MyGk2-0005MV-UT for ged-emacs-devel@m.gmane.org; Thu, 15 Oct 2009 05:11:03 +0200 Original-Received: from localhost ([127.0.0.1]:59309 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyGk1-0006vu-TW for ged-emacs-devel@m.gmane.org; Wed, 14 Oct 2009 23:11:01 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MyGjw-0006vh-Hr for emacs-devel@gnu.org; Wed, 14 Oct 2009 23:10:56 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MyGjr-0006v7-9b for emacs-devel@gnu.org; Wed, 14 Oct 2009 23:10:56 -0400 Original-Received: from [199.232.76.173] (port=57286 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MyGjr-0006v4-5z for emacs-devel@gnu.org; Wed, 14 Oct 2009 23:10:51 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.183]:2122 helo=ironport2-out.pppoe.ca) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MyGjq-0008Gy-Rw for emacs-devel@gnu.org; Wed, 14 Oct 2009 23:10:50 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AqYEAN8v1kpMCqsb/2dsb2JhbACBUdgCgjKBfASHdYJ4 X-IronPort-AV: E=Sophos;i="4.44,563,1249272000"; d="scan'208";a="47597213" Original-Received: from 76-10-171-27.dsl.teksavvy.com (HELO ceviche.home) ([76.10.171.27]) by ironport2-out.pppoe.ca with ESMTP; 14 Oct 2009 23:10:49 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 4CB81B4100; Wed, 14 Oct 2009 23:10:49 -0400 (EDT) In-Reply-To: <200910141558.n9EFwJVd023731@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Wed, 14 Oct 2009 08:58:19 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: Genre and OS details not recognized. X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:116154 Archived-At: > vc-annotate.el assumes that the file name is always the same. This is > not true when showing copies/renames. This varies a lot between backends. E.g. IIRC in Svn and Arch, the file-name is basically ignored (replaced by some notion of file identity that is preserved by renaming), so in your example the f.csh file is the only name that would appear and revision "14d0ca93" of that file simply had the name "t.csh" at that time, but you don't need to know about it to get the `annotate' output, or the `diff' output or ... So providing support for it in the generic part of the code may turn out to be trickier than your patch suggests. Stefan