From: Stefan Monnier <monnier@iro.umontreal.ca>
To: SAITO Takuya <tabmore@gmail.com>
Subject: bug#6275: 23.2; warning-suppress-types is void after defadvice
Date: Tue, 08 Jun 2010 21:22:25 -0400 [thread overview]
Message-ID: <jwv631t80nv.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <20100526.232850.112543538.tabmore@gmail.com> (SAITO Takuya's message of "Wed, 26 May 2010 23:28:50 +0900 (JST)")
forcemerge 6275 6373
thanks
> Debugger entered--Lisp error: (void-variable warning-suppress-types)
[...]
> ad-compile-function() binds warning-suppress-types with let.
> I guess warnings.el is loaded inside of that let-binding.
Indeed, thank you. I've installed the patch below which should fix it.
Stefan
=== modified file 'lisp/emacs-lisp/advice.el'
--- lisp/emacs-lisp/advice.el 2010-02-15 20:03:22 +0000
+++ lisp/emacs-lisp/advice.el 2010-06-09 01:16:08 +0000
@@ -2684,6 +2684,8 @@
;; because `byte-compile' uses `fset':
(ad-with-auto-activation-disabled
(require 'bytecomp)
+ (require 'warnings) ;To define warning-suppress-types
+ ;before we let-bind it.
(let ((symbol (make-symbol "advice-compilation"))
(byte-compile-warnings byte-compile-warnings)
;; Don't pop up windows showing byte-compiler warnings.
prev parent reply other threads:[~2010-06-09 1:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-26 14:28 bug#6275: 23.2; warning-suppress-types is void after defadvice SAITO Takuya
2010-06-09 1:22 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv631t80nv.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=tabmore@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.