From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [PATCH 2/2] Make font-lock honor parents mode of current major-mode Date: Wed, 09 Feb 2011 11:37:48 -0500 Message-ID: References: <1297190593-4585-1-git-send-email-julien@danjou.info> <1297190593-4585-2-git-send-email-julien@danjou.info> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1297269487 11885 80.91.229.12 (9 Feb 2011 16:38:07 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 9 Feb 2011 16:38:07 +0000 (UTC) Cc: emacs-devel@gnu.org To: Julien Danjou Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Wed Feb 09 17:38:03 2011 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PnD3J-0008GY-U3 for ged-emacs-devel@m.gmane.org; Wed, 09 Feb 2011 17:38:02 +0100 Original-Received: from localhost ([127.0.0.1]:35065 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnD3J-0007lp-94 for ged-emacs-devel@m.gmane.org; Wed, 09 Feb 2011 11:38:01 -0500 Original-Received: from [140.186.70.92] (port=55662 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PnD3B-0007k5-Qm for emacs-devel@gnu.org; Wed, 09 Feb 2011 11:37:54 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PnD38-0007hq-C2 for emacs-devel@gnu.org; Wed, 09 Feb 2011 11:37:53 -0500 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:13865 helo=ironport2-out.pppoe.ca) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PnD38-0007hN-43 for emacs-devel@gnu.org; Wed, 09 Feb 2011 11:37:50 -0500 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvsEAPNRUk1FxIyy/2dsb2JhbAClQ3S8RIVcBIR/jyk X-IronPort-AV: E=Sophos;i="4.60,446,1291611600"; d="scan'208";a="91031086" Original-Received: from 69-196-140-178.dsl.teksavvy.com (HELO ceviche.home) ([69.196.140.178]) by ironport2-out.pppoe.ca with ESMTP/TLS/ADH-AES256-SHA; 09 Feb 2011 11:37:49 -0500 Original-Received: by ceviche.home (Postfix, from userid 20848) id F0057660D4; Wed, 9 Feb 2011 11:37:48 -0500 (EST) In-Reply-To: <1297190593-4585-2-git-send-email-julien@danjou.info> (Julien Danjou's message of "Tue, 8 Feb 2011 19:43:13 +0100") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:135805 Archived-At: > This allows to add font-lock keyword to prog-mode directly, so every other > children mode will use them. Making inheritance work with font-lock keywords is a good idea, but this is the wrong way to do it. The right way is to take advantage of the way inheritance works. E.g. use a variable which modes would *modify* rather than just set. E.g. somehow convince all modes to use the equivalent of font-lock-add-keywords. Stefan