From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#8613: "mode:" for minor-mode breaks set-visited-file-name Date: Wed, 04 May 2011 09:52:42 -0300 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1304514430 12980 80.91.229.12 (4 May 2011 13:07:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 4 May 2011 13:07:10 +0000 (UTC) Cc: 8613@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Wed May 04 15:07:05 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QHbnD-0006IA-RG for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 May 2011 15:07:03 +0200 Original-Received: from localhost ([::1]:43745 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHbnD-0007pR-8x for geb-bug-gnu-emacs@m.gmane.org; Wed, 04 May 2011 09:07:03 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:46562) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHbnA-0007ou-95 for bug-gnu-emacs@gnu.org; Wed, 04 May 2011 09:07:01 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QHbn9-0001RZ-9a for bug-gnu-emacs@gnu.org; Wed, 04 May 2011 09:07:00 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:56760) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QHbn9-0001RV-85 for bug-gnu-emacs@gnu.org; Wed, 04 May 2011 09:06:59 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1QHbZe-0002eo-AY; Wed, 04 May 2011 08:53:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-To: owner@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 May 2011 12:53:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 8613 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 8613-submit@debbugs.gnu.org id=B8613.130451357910203 (code B ref 8613); Wed, 04 May 2011 12:53:02 +0000 Original-Received: (at 8613) by debbugs.gnu.org; 4 May 2011 12:52:59 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QHbZb-0002eV-Bj for submit@debbugs.gnu.org; Wed, 04 May 2011 08:52:59 -0400 Original-Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1QHbZZ-0002eJ-3S for 8613@debbugs.gnu.org; Wed, 04 May 2011 08:52:57 -0400 Original-Received: from 121-249-126-200.fibertel.com.ar ([200.126.249.121]:8669 helo=ceviche.home) by fencepost.gnu.org with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1QHbZT-00055q-3p; Wed, 04 May 2011 08:52:51 -0400 Original-Received: by ceviche.home (Postfix, from userid 20848) id 2F1FA662FC; Wed, 4 May 2011 09:52:42 -0300 (ART) In-Reply-To: (Glenn Morris's message of "Tue, 03 May 2011 22:08:17 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Wed, 04 May 2011 08:53:02 -0400 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:46197 Archived-At: >>> The fact that "mode:" is allowed to indicate both major and minor modes >>> in file local variables is problematic. Things would be much simpler if >>> a different convention were used for minor modes. > So; shall we try to come up with a new convention for enabling > minor-modes via file-local variables, and deprecate using mode: for that? Yes, please. > All "mode:" does is funcall FOO-mode [1], which is nothing that can't be > done with :eval, except the latter will prompt for confirmation. Rather > than adding eg "minor-mode:", maybe safe-local-eval-forms could be > extended with a regexp element matching something like "([a-z]+-mode)". Not a bad idea, tho I'd much rather add a (run-hook-with-args-until-success 'safe-local-eval-functions) instead rather than rely on regexps. Another option is to let define-minor-mode place a `safe-local-eval-function' property on the minor-mode's symbol. Stefan