all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* bug#8785: 24.0.50; progress-reporter shows percentage with no space
@ 2011-06-02 10:36 Katsumi Yamaoka
  2011-06-02 12:38 ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Katsumi Yamaoka @ 2011-06-02 10:36 UTC (permalink / raw)
  To: 8785

When I send a big mail using smtpmail, I get:

Sending email
Sending email12%
Sending email85%
Sending email87%
Sending email90%
Sending email92%
Sending email95%
Sending email97%
Sending emaildone

SPC is needed between text and percentage, I think.  Is what
should be fixed `progress-reporter-do-update', or should every
program that uses `make-progress-reporter' add SPC to the first
argument?






^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#8785: 24.0.50; progress-reporter shows percentage with no space
  2011-06-02 10:36 bug#8785: 24.0.50; progress-reporter shows percentage with no space Katsumi Yamaoka
@ 2011-06-02 12:38 ` Stefan Monnier
  2011-06-02 14:34   ` Stefan Monnier
  0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2011-06-02 12:38 UTC (permalink / raw)
  To: Katsumi Yamaoka; +Cc: 8785

> When I send a big mail using smtpmail, I get:
> Sending email
> Sending email12%
> Sending email85%
> Sending email87%
> Sending email90%
> Sending email92%
> Sending email95%
> Sending email97%
> Sending emaildone

> SPC is needed between text and percentage, I think.  Is what

Actually it's a " ... " that's missing.

> should be fixed `progress-reporter-do-update', or should every
> program that uses `make-progress-reporter' add SPC to the first
> argument?

I'd tend to say "better fix it in make-progress-reporter", but it might
be too late to change it.


        Stefan





^ permalink raw reply	[flat|nested] 3+ messages in thread

* bug#8785: 24.0.50; progress-reporter shows percentage with no space
  2011-06-02 12:38 ` Stefan Monnier
@ 2011-06-02 14:34   ` Stefan Monnier
  0 siblings, 0 replies; 3+ messages in thread
From: Stefan Monnier @ 2011-06-02 14:34 UTC (permalink / raw)
  To: Katsumi Yamaoka; +Cc: 8785-done

>> should be fixed `progress-reporter-do-update', or should every
>> program that uses `make-progress-reporter' add SPC to the first
>> argument?

> I'd tend to say "better fix it in make-progress-reporter", but it might
> be too late to change it.

I felt optimistic, so I'm going to install the patch below (as soon as
bzr.sv.gnu.org comes back to life),


        Stefan


=== modified file 'lisp/subr.el'
--- lisp/subr.el	2011-06-01 14:19:45 +0000
+++ lisp/subr.el	2011-06-02 14:31:56 +0000
@@ -3702,6 +3702,8 @@
 `float-time' is not present, time is not tracked at all.  If the
 OS is not capable of measuring fractions of seconds, this
 parameter is effectively rounded up."
+  (when (string-match "[[:alnum:]]\\'" message)
+    (setq message (concat message "...")))
   (unless min-time
     (setq min-time 0.2))
   (let ((reporter






^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2011-06-02 14:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-06-02 10:36 bug#8785: 24.0.50; progress-reporter shows percentage with no space Katsumi Yamaoka
2011-06-02 12:38 ` Stefan Monnier
2011-06-02 14:34   ` Stefan Monnier

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.