From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#10133: (24.0.91; mark-active) Date: Tue, 29 Nov 2011 08:52:30 -0500 Message-ID: References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: dough.gmane.org 1322574800 5965 80.91.229.12 (29 Nov 2011 13:53:20 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 29 Nov 2011 13:53:20 +0000 (UTC) Cc: Richard Copley , 10133@debbugs.gnu.org To: Glenn Morris Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Tue Nov 29 14:53:16 2011 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1RVO7X-00051t-Qo for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Nov 2011 14:53:15 +0100 Original-Received: from localhost ([::1]:34968 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVO7X-0002ov-GK for geb-bug-gnu-emacs@m.gmane.org; Tue, 29 Nov 2011 08:53:15 -0500 Original-Received: from eggs.gnu.org ([140.186.70.92]:50566) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVO7Q-0002oc-Jl for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 08:53:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1RVO7K-0003t2-VG for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 08:53:08 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:43704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1RVO7K-0003ss-Tm for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 08:53:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.69) (envelope-from ) id 1RVO9G-0006Iz-8I for bug-gnu-emacs@gnu.org; Tue, 29 Nov 2011 08:55:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: debbugs-submit-bounces@debbugs.gnu.org Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 29 Nov 2011 13:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 10133 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: Original-Received: via spool by 10133-submit@debbugs.gnu.org id=B10133.132257487624201 (code B ref 10133); Tue, 29 Nov 2011 13:55:02 +0000 Original-Received: (at 10133) by debbugs.gnu.org; 29 Nov 2011 13:54:36 +0000 Original-Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVO8q-0006IH-7o for submit@debbugs.gnu.org; Tue, 29 Nov 2011 08:54:36 -0500 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RVO8m-0006I9-SL for 10133@debbugs.gnu.org; Tue, 29 Nov 2011 08:54:34 -0500 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id pATDqVRW008973; Tue, 29 Nov 2011 08:52:31 -0500 Original-Received: by pastel.home (Postfix, from userid 20848) id CDF834E758; Tue, 29 Nov 2011 08:52:30 -0500 (EST) In-Reply-To: (Glenn Morris's message of "Mon, 28 Nov 2011 21:54:24 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.0.91 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4055=0 X-NAI-Spam-Version: 2.2.0.9286 : core <4055> : streams <706258> : uri <1018288> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Resent-Date: Tue, 29 Nov 2011 08:55:02 -0500 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:54413 Archived-At: >> I guess the bug is that the functions in "log-view.el" should be using >> `use-region-p' or `region-active-p' rather than `mark-active'. > Why? That would make them dependent on transient mark mode. But the current behavior means that without transient-mark-mode, if you've set the mark at some point in the past, you can't do a "diff with current file" any more, only a "diff between revision at point and revision at mark". > Nowhere in the doc of eg log-view-diff does it say that the function > behaves differently if transient mark mode is on. So I don't see that > there is a bug here. It's maybe not a bug, but it's a limitation. I think `use-region-p' would make a lot of sense here nowadays (there was no temporary tmm back when I wrote the code, so something like use-region-p would have made the "diff between 2 revisions" inaccessible to non-tmm users, but this limit has now been lifted). Stefan