bug#10172: 24.0.92; compile-tests.el failure

bug#10172: 24.0.92; compile-tests.el failure

[Chong Yidong]

With latest trunk, `make check' fails with:

1 unexpected results:
   FAILED  compile-test-error-regexps

From further debugging, the columns reported by compilation-parse-errors
are now off by one.  Did the latest changes to compile.el switch the
column numbers from being 0-indexed to 1-indexed?

In GNU Emacs 24.0.92.1 (x86_64-unknown-linux-gnu, GTK+ Version 3.2.0)
 of 2011-12-01 on furball
Windowing system distributor `The X.Org Foundation', version 11.0.11004000
configured using `configure  '--with-x-toolkit=gtk3' 'CFLAGS=-g''

bug#10172: 24.0.92; compile-tests.el failure

[Stefan Monnier]

> With latest trunk, `make check' fails with:
> 1 unexpected results:
>    FAILED  compile-test-error-regexps

>> From further debugging, the columns reported by compilation-parse-errors
> are now off by one.  Did the latest changes to compile.el switch the
> column numbers from being 0-indexed to 1-indexed?

Well, it moved the moment where compilation-first-column is used, so
that impacts the values stored in the `compilation-message' property
(which used to have compilation-first-column applied but is now "raw").


        Stefan