From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Christopher Genovese <genovese.cr@gmail.com>
Cc: 10191-done@debbugs.gnu.org
Subject: bug#10191: dired-query (in dired-aux.el) fails for certain help-char's, Emacs 23 and 24
Date: Fri, 02 Dec 2011 09:18:35 -0500 [thread overview]
Message-ID: <jwv62hz9i2q.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <CAPum5Fgg4ViPoEtBG_kTYwgsWwnesB35jrgY9VEYhXAqkBX55Q@mail.gmail.com> (Christopher Genovese's message of "Fri, 2 Dec 2011 01:27:02 -0500")
> ; original
> (if help-form
> (format " [Type yn!q or %s] "
> (key-description
> (char-to-string help-char)))
> " [Type y, n, q or !] ")
> When (characterp help-char) is nil, as in my case, char-to-string raises an
> error.
Thanks. I've installed the patch below which should fix your problem,
Stefan
=== modified file 'lisp/dired-aux.el'
--- lisp/dired-aux.el 2011-11-17 09:09:20 +0000
+++ lisp/dired-aux.el 2011-12-02 14:14:09 +0000
@@ -927,8 +927,7 @@
(concat (apply 'format prompt args)
(if help-form
(format " [Type yn!q or %s] "
- (key-description
- (char-to-string help-char)))
+ (key-description (vector help-char)))
" [Type y, n, q or !] ")))
(set sym (setq char (read-char-choice prompt char-choices)))
(if (memq char '(?y ?\s ?!)) t)))))
next prev parent reply other threads:[~2011-12-02 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-02 6:27 bug#10191: dired-query (in dired-aux.el) fails for certain help-char's, Emacs 23 and 24 Christopher Genovese
2011-12-02 8:36 ` Andreas Schwab
2011-12-02 13:22 ` Christopher Genovese
2011-12-02 14:18 ` Stefan Monnier [this message]
2011-12-02 16:37 ` Andreas Schwab
2011-12-02 17:26 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv62hz9i2q.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=10191-done@debbugs.gnu.org \
--cc=genovese.cr@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.