From: Stefan Monnier <monnier@iro.umontreal.ca>
To: martin rudalics <rudalics@gmx.at>
Cc: Michael Bach <phaebz@gmail.com>, 10348@debbugs.gnu.org
Subject: bug#10348: 24.0.92; Save and load window states
Date: Sun, 25 Dec 2011 06:00:49 -0500 [thread overview]
Message-ID: <jwv62h4ylbm.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <4EF59B02.9060608@gmx.at> (martin rudalics's message of "Sat, 24 Dec 2011 10:27:30 +0100")
>> No, it would address this particular bug-report, but similar problems
>> may reappear at any time.
> Yes. Someone could do (set-window-dedicated-p nil (selected-window)).
Yup.
>>> IIUC this is what desktop does. The problem is rather that we would
>>> have to distinguish between values needed for intra-session purposes and
>>> those that make sense for inter-session purposes too.
>> I'm not sure distinguishing the two is needed (especially for
>> window-state-*).
> So your proposed `window-state-saved-parameters' would never save and
> restore a thing like the "clone-of" parameter?
Not quite "never", but at least not before we manage to serialize its value.
>>> You mean that anyone who misuses that variable (by including, for
>>> example, a parameter that actually stores a window object as value)
>>> would be on her own?
>> I don't see any harm in it.
> Any application setting a window parameter to some non-standard value
> would be held responsible for this.
That's right. We should probably try to make the code a bit more robust
so that the "invalid read syntax" error gets turned into a warning.
>> Not if we make this variable specify which parameters to include in
>> window-states, rather than only which parameters to write to a file.
>> Or maybe I don't understand the problem you're referring to.
> The window-state-* functions are primarily intended for inter-session
> use. So if we can save a bad value, the bug will be usually detected
> when it's too late.
I can't see any scenario where such errors could really be detected earlier.
>>>> After all the window-configurations don't save&restore
>>>> window parameters.
>>> Currently they do (unless you modify them destructively). Otherwise,
>>> side windows and atomic windows won't work.
>> Oh, I see that's another change in Emacs-24. It's actually problematic
>> because set-window-parameter does operate destructively,
> `set-window-parameter' is harmless. The problem occurs only if you
> modify a window parameter's value destructively.
I must be missing something: set-window-parameter does "modify a window
parameter's value destructively".
>> so it makes the semantics rather irregular.
> It's precisely the same as for the dedicated status of a window.
Is it?
The irregularity I'm referring to, is that set-window-configuration will
remove parameters that were added since the save, but will not undo the
changes to the parameters that were modified since the save.
Stefan
next prev parent reply other threads:[~2011-12-25 11:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-21 20:41 bug#10348: 24.0.92; Save and load window states Michael Bach
2011-12-22 17:04 ` martin rudalics
2011-12-22 17:14 ` Drew Adams
2011-12-22 21:57 ` Juri Linkov
2011-12-22 22:57 ` Juanma Barranquero
2011-12-22 23:34 ` Juri Linkov
2011-12-23 10:30 ` martin rudalics
2011-12-23 15:10 ` Drew Adams
2011-12-24 19:04 ` Juri Linkov
2011-12-23 10:30 ` martin rudalics
2011-12-23 1:03 ` Stefan Monnier
2011-12-23 10:31 ` martin rudalics
2011-12-23 11:30 ` Michael Bach
2011-12-23 21:14 ` Juri Linkov
2011-12-24 9:26 ` martin rudalics
2011-12-24 19:08 ` Juri Linkov
2011-12-25 13:57 ` martin rudalics
2011-12-24 0:07 ` Stefan Monnier
2011-12-24 9:27 ` martin rudalics
2011-12-25 11:00 ` Stefan Monnier [this message]
2011-12-25 13:58 ` martin rudalics
2011-12-25 21:36 ` Juri Linkov
2011-12-26 11:07 ` martin rudalics
2011-12-26 0:22 ` Stefan Monnier
2011-12-26 11:07 ` martin rudalics
2011-12-26 18:25 ` martin rudalics
2011-12-27 23:23 ` Stefan Monnier
2011-12-28 15:57 ` martin rudalics
2011-12-28 23:09 ` Stefan Monnier
2011-12-29 11:39 ` martin rudalics
2012-01-16 9:42 ` martin rudalics
2011-12-28 9:50 ` martin rudalics
2011-12-24 19:17 ` Juri Linkov
2012-01-16 9:43 ` martin rudalics
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv62h4ylbm.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=10348@debbugs.gnu.org \
--cc=phaebz@gmail.com \
--cc=rudalics@gmx.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.