From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Magne Ingebrigtsen <larsi@gnus.org>
Cc: Juanma Barranquero <lekktu@gmail.com>, sds@gnu.org, emacs-devel@gnu.org
Subject: Re: more candidates for obsoletion
Date: Sun, 13 May 2012 22:20:36 -0400 [thread overview]
Message-ID: <jwv62bzldb8.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m31umokjzt.fsf@stories.gnus.org> (Lars Magne Ingebrigtsen's message of "Sun, 13 May 2012 20:34:46 +0200")
> static void
> set_message (const char *s, Lisp_Object string,
> EMACS_INT nbytes, int multibyte_p)
> {
> + int count = SPECPDL_INDEX ();
> +
> message_enable_multibyte
> = ((s && multibyte_p)
> || (STRINGP (string) && STRING_MULTIBYTE (string)));
> @@ -10420,6 +10431,19 @@
> (intptr_t) s, string, nbytes, multibyte_p);
> message_buf_print = 0;
> help_echo_showing_p = 0;
> +
> + record_unwind_save_match_data ();
> +
> + if (! debugging &&
> + ! NILP (Vdebug_on_message) &&
> + STRINGP (Vdebug_on_message) &&
> + ! NILP (Fstring_match (Vdebug_on_message, string, Qnil))) {
> + debugging = 1;
> + record_unwind_protect (undo_debugging, Qnil);
> + call_debugger (Fcons (Qerror, Fcons (string, Qnil)));
> + }
> +
> + unbind_to (count, Qnil);
> }
Doesn't look too bad. A few questions and suggestions:
- !NILP is implied y STRINGP.
- You might prefer to use fast_string_match.
- Is the recursive debugging a problem you've found to show up
unavoidably all the time, or are you just being cautious?
- You could turn your `debugging' into a Lisp var (call it
"inhibit-debug-on-message"), or you could let-bind debug-on-message to
nil around the call to the debugger.
Stefan
next prev parent reply other threads:[~2012-05-14 2:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 6:43 more candidates for obsoletion Glenn Morris
2012-05-01 19:51 ` Sam Steingold
2012-05-01 22:06 ` Juanma Barranquero
2012-05-01 22:25 ` Lars Magne Ingebrigtsen
2012-05-01 22:28 ` Lars Magne Ingebrigtsen
2012-05-02 13:02 ` Stefan Monnier
2012-05-13 18:34 ` Lars Magne Ingebrigtsen
2012-05-14 2:20 ` Stefan Monnier [this message]
2012-09-04 18:10 ` Lars Ingebrigtsen
2012-09-04 19:29 ` Stefan Monnier
2012-09-04 21:24 ` Lars Ingebrigtsen
2012-05-02 5:03 ` Thierry Volpiatto
2012-05-02 9:25 ` Michael Albinus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv62bzldb8.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
--cc=lekktu@gmail.com \
--cc=sds@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.