* bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus
@ 2012-07-23 9:35 martin rudalics
2012-07-23 10:08 ` Stefan Monnier
0 siblings, 1 reply; 3+ messages in thread
From: martin rudalics @ 2012-07-23 9:35 UTC (permalink / raw)
To: 12030
`yes-or-no-p' eventually winds up calling read_minibuf which does
if (minibuffer_auto_raise)
Fraise_frame (mini_frame);
...
if (!EQ (mini_frame, selected_frame))
Fredirect_frame_focus (selected_frame, mini_frame);
`y-or-n-p' instead does
(when minibuffer-auto-raise
(raise-frame (window-frame (minibuffer-window))))
...
(redirect-frame-focus (window-frame (minibuffer-window)))
which strikes me as incongruent with the former since IIUC the last form
only redirects the minibuffer-window frame's focus to itself. If this
is not the intended behavior, a possible source of the bug is that the
second argument of `redirect-frame-focus' is not mandatory. As a
consequence, authors (including me) tend to consider its first argument
reference the frame that shall be focused.
martin
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus
2012-07-23 9:35 bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus martin rudalics
@ 2012-07-23 10:08 ` Stefan Monnier
2012-07-25 9:46 ` martin rudalics
0 siblings, 1 reply; 3+ messages in thread
From: Stefan Monnier @ 2012-07-23 10:08 UTC (permalink / raw)
To: martin rudalics; +Cc: 12030
> only redirects the minibuffer-window frame's focus to itself. If this
> is not the intended behavior, a possible source of the bug is that the
> second argument of `redirect-frame-focus' is not mandatory. As a
I think you're right. Could you make it "soft-mandatory" by adding
an `advertised-signature'?
Stefan
^ permalink raw reply [flat|nested] 3+ messages in thread
* bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus
2012-07-23 10:08 ` Stefan Monnier
@ 2012-07-25 9:46 ` martin rudalics
0 siblings, 0 replies; 3+ messages in thread
From: martin rudalics @ 2012-07-25 9:46 UTC (permalink / raw)
To: 12030-done
> I think you're right. Could you make it "soft-mandatory" by adding
> an `advertised-signature'?
Done.
martin
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2012-07-25 9:46 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-07-23 9:35 bug#12030: 24.0.97; y-or-n-p and redirect-frame-focus martin rudalics
2012-07-23 10:08 ` Stefan Monnier
2012-07-25 9:46 ` martin rudalics
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.