From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Jonas Bernoulli <jonas@bernoul.li>
Cc: 13207@debbugs.gnu.org
Subject: bug#13207: lisp-mnt.el improvements
Date: Mon, 17 Dec 2012 12:58:48 -0500 [thread overview]
Message-ID: <jwv62404lcl.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <878v8wve4m.fsf@bernoul.li> (Jonas Bernoulli's message of "Mon, 17 Dec 2012 17:26:33 +0100")
> 1. Add function lm-homepage
> (lm-header "\\(?:x-\\)?\\(?:homepage\\|url\\)")
> These keywords are used quite often, most often without the X- prefix.
Sounds OK.
> 2. lm-section-end: the end is now always before the following
> non-comment text
> Many people don't add ;;; Code: after the header. As a result
> lm-commentary was often way of (like eof!) and lm-commentary returned
> text that isn't part of the commentary but code.
Good.
> 3. lm-header, lm-header-multiline: wrap with save-match-data
This one doesn't sound right. The callers should be fixed instead.
> 4. lm-header-multiline: continuation lines now need to be intended more
> than the first line. E.g:
> ;; Keyword: value
> ;; more value
> This is necessary because some built-in libraries contain things
> like:
> ;; Author: Kenichi HANDA <handa@etl.go.jp>
> ;; (according to ack.texi)
> And some third-party libraries contain things like:
> ;; Keywords: key words
> ;; This file is not part of Emacs
> Among the 3500 packages mirrored on the Emacsmirror there are only
> three where this change results in lines intended as continuation
> lines not to be recognised anymore. At the same time this change
> fixes ~50 errors.
An important measure is how much breakage/improvement does it introduce
when applied to files that are expected to do thing right (e.g. files in
emacs/lisp and in elpa/packages). I'm OK with making lisp-mnt.el more
forgiving, but it should not come at the cost of those packages that do
things right.
Stefan
next prev parent reply other threads:[~2012-12-17 17:58 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-17 16:26 bug#13207: lisp-mnt.el improvements Jonas Bernoulli
2012-12-17 17:58 ` Stefan Monnier [this message]
2012-12-17 21:58 ` Jonas Bernoulli
2012-12-18 1:29 ` Stefan Monnier
2012-12-19 15:38 ` Jonas Bernoulli
2012-12-19 19:52 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv62404lcl.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=13207@debbugs.gnu.org \
--cc=jonas@bernoul.li \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.