From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#16116: 24.3.50; smie-indent-close aligns inner closing paren with the outer opening paren Date: Sat, 14 Dec 2013 20:50:56 -0500 Message-ID: References: <87sity96he.fsf@yandex.ru> <6B783955-B72E-4876-BCF2-C864F3D74A62@sanityinc.com> <87y53niicw.fsf@yandex.ru> <87r49fe1d2.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1387072336 8169 80.91.229.3 (15 Dec 2013 01:52:16 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 15 Dec 2013 01:52:16 +0000 (UTC) Cc: 16116@debbugs.gnu.org, Steve Purcell To: Dmitry Gutov Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Sun Dec 15 02:52:21 2013 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Vs0sW-00011I-PY for geb-bug-gnu-emacs@m.gmane.org; Sun, 15 Dec 2013 02:52:20 +0100 Original-Received: from localhost ([::1]:49141 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vs0sW-0003BI-1G for geb-bug-gnu-emacs@m.gmane.org; Sat, 14 Dec 2013 20:52:20 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vs0sM-0003B8-2w for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 20:52:17 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Vs0sE-0000MC-O3 for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 20:52:10 -0500 Original-Received: from debbugs.gnu.org ([140.186.70.43]:36495) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Vs0sE-0000Ll-Ke for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 20:52:02 -0500 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Vs0sE-0008MU-Cl for bug-gnu-emacs@gnu.org; Sat, 14 Dec 2013 20:52:02 -0500 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 15 Dec 2013 01:52:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 16116 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 16116-submit@debbugs.gnu.org id=B16116.138707226432069 (code B ref 16116); Sun, 15 Dec 2013 01:52:02 +0000 Original-Received: (at 16116) by debbugs.gnu.org; 15 Dec 2013 01:51:04 +0000 Original-Received: from localhost ([127.0.0.1]:50514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vs0rH-0008LA-OP for submit@debbugs.gnu.org; Sat, 14 Dec 2013 20:51:04 -0500 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:34173) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Vs0rE-0008Kk-NN for 16116@debbugs.gnu.org; Sat, 14 Dec 2013 20:51:01 -0500 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.DIT.UMontreal.CA (8.14.1/8.14.1) with ESMTP id rBF1ovkL031202; Sat, 14 Dec 2013 20:50:58 -0500 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 9FEFAAE358; Sat, 14 Dec 2013 20:50:56 -0500 (EST) In-Reply-To: <87r49fe1d2.fsf@yandex.ru> (Dmitry Gutov's message of "Sat, 14 Dec 2013 20:25:29 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4792=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4792> : inlines <324> : streams <1090994> : uri <1624280> X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:81998 Archived-At: >> Also, if it's done in the rules-function, the >> function may return different results depending on context. > True, but so far I don't see a situation in Ruby where it'd depend on > the context. Agreed, but we're talking about a change in smie.el, not in ruby-mode.el ;-) >>> or make smie-indent-functions buffer-local and replace >>> smie-indent-close there with a modified implementation. >> This approach would work if the requirement is very specific to one >> particular major mode, but in this case, it seems to be a fairly >> common one. > I believe this argument also works against doing it in the rules > function, and in favor of adding a defvar. I don't think so: setting the var is a one-liner, adding the rule to the rule-function is also a one-liner. So either way is just as easy for the major-mode. By contrast, setting smie-indent-functions buffer-locally, then removing smie-indent-close from it and adding some other function requires a lot more code, and a lot more brittle as well (the ordering in smie-indent-functions is important, the set of functions in there and their order is not guaranteed to stay unchanged in future versions, the replacement function needs to be written (delegating to smie-indent-close seems like it might not work), ... Stefan