From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: 16334@debbugs.gnu.org
Subject: bug#16334: 24.3.50; company-capf eats the first char in IELM filename completions
Date: Mon, 06 Jan 2014 10:23:16 -0500 [thread overview]
Message-ID: <jwv61pxrvrh.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <52CA4035.2020302@yandex.ru> (Dmitry Gutov's message of "Mon, 06 Jan 2014 09:33:41 +0400")
>>> `completion-file-name-table' is more of an exception, I think. But if
>>> it was only passed the segment of STRING after the last path
>>> separator, it could still look behind it in the buffer and see the
>>> full path.
>> But the completion may actually want to *change* the text before
>> the boundary. E.g. completion of /u/s/d to /usr/share/doc.
> In that case, "/usr/share/doc" is the completion candidate, not "doc",
> right?
Not sure what you mean by "completion candidate":
try-completion and all-completions will both return nil because there's
no "/u/s" directory. Assuming we use partial-completion style,
completion-try-completion should return "/usr/share/doc" and
completion-all-completions should return ("usr/share/doc"), i.e. without
the leading "/". If we had started from "/usr/s/d" the results would
have been the same except completion-all-completions would return
("share/doc").
> To be clear, I'm not convinced that the notion of "sub-fields" is
> useful. Defining limits to the text that can be affected by completion only
> looks good to me from the presentation point of view: if the candidate
> strings can be shorter, we can show more of them in the *Candidates* buffer,
> whereas it's less useful for popup-style UIs where the candidates are
> displayed vertically anyway.
Then just have company-capf check completion-boundaries and concat the
missing prefix to every element returned by all-completions.
> IOW, if I were to add a `boundaries' action to company-backends API, it
> would only be used for presentation: the popup will cut off that many
> characters from the candidate strings, and it will be rendered that many
> columns to the right.
If you want to let Company provide completion styles like
partial-completion you'll need some additional info about "subfields".
But as long as you limit yourself to prefix or substring completion you
don't need that.
> Come to think of it, though, this new action may be incompatible with the
> notion of merged backends. If we have candidates that come from backends
> that return the same prefix but different boundaries, there's no way to
> reflect the boundaries in the popup.
Yup. Just like you have a problem when the start/end of the
completion text is not identical. E.g. you could have a "word" backend
and a "varname" backend, and you type "my_fanc" and now the "word"
backend wants to complete "fanc" whereas the varname backend wants to
complete "my_fanc".
Stefan
next prev parent reply other threads:[~2014-01-06 15:23 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-03 23:20 bug#16334: 24.3.50; company-capf eats the first char in IELM filename completions Dmitry Gutov
2014-01-04 5:00 ` Stefan Monnier
2014-01-05 2:20 ` Dmitry Gutov
2014-01-05 3:17 ` Dmitry Gutov
2014-01-05 4:53 ` Stefan Monnier
2014-01-06 5:33 ` Dmitry Gutov
2014-01-06 15:23 ` Stefan Monnier [this message]
2014-01-07 2:52 ` Dmitry Gutov
2014-01-08 3:33 ` Stefan Monnier
2014-01-09 6:21 ` Dmitry Gutov
2014-01-09 16:00 ` Stefan Monnier
2014-01-10 6:23 ` Dmitry Gutov
2014-01-10 14:58 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv61pxrvrh.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=16334@debbugs.gnu.org \
--cc=dgutov@yandex.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.