From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] emacs-24 r116836: Fix keyword argument parsing. Please bootstrap. Date: Sun, 23 Mar 2014 21:43:46 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1395625442 22796 80.91.229.3 (24 Mar 2014 01:44:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 24 Mar 2014 01:44:02 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Mar 24 02:44:10 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WRtvu-0002O8-3T for ged-emacs-devel@m.gmane.org; Mon, 24 Mar 2014 02:44:10 +0100 Original-Received: from localhost ([::1]:34109 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRtvt-0006Fg-OT for ged-emacs-devel@m.gmane.org; Sun, 23 Mar 2014 21:44:09 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45255) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRtvk-0006FR-3R for emacs-devel@gnu.org; Sun, 23 Mar 2014 21:44:07 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1WRtvc-0007cB-KG for emacs-devel@gnu.org; Sun, 23 Mar 2014 21:43:59 -0400 Original-Received: from chene.dit.umontreal.ca ([132.204.246.20]:43095) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WRtvc-0007c3-Ff for emacs-devel@gnu.org; Sun, 23 Mar 2014 21:43:52 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by chene.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s2O1i4a6029637; Sun, 23 Mar 2014 21:44:04 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 4599D6017C; Sun, 23 Mar 2014 21:43:46 -0400 (EDT) In-Reply-To: (Daniel Colascione's message of "Sun, 23 Mar 2014 06:00:46 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV4890=0 X-NAI-Spam-Version: 2.3.0.9362 : core <4890> : inlines <634> : streams <1143616> : uri <1708054> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.20 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:170893 Archived-At: > + * emacs-lisp/cl-macs.el (cl--do-arglist): Use a little `cl-loop' > + list to look for keyword arguments instead of `memq', fixing > + (Bug#3647) --- unfortunately, only for freshly-compiled code. > + Please make bootstrap. Have you checked the performance and code-size impact of this change? Maybe it's OK to try it on trunk, but it seems much too risky performancewise for 24.4. There is no hurry to fix this: the bug has been with us forever (IIRC it was even documented in CL's texinfo). Stefan