From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: [Emacs-diffs] trunk r116989: 2014-04-17 Daniel Colascione Date: Thu, 17 Apr 2014 08:52:15 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1397739181 20932 80.91.229.3 (17 Apr 2014 12:53:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 17 Apr 2014 12:53:01 +0000 (UTC) Cc: emacs-devel@gnu.org To: Daniel Colascione Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Apr 17 14:52:54 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1WaloC-000405-Fh for ged-emacs-devel@m.gmane.org; Thu, 17 Apr 2014 14:52:52 +0200 Original-Received: from localhost ([::1]:60725 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1WaloC-0004yt-68 for ged-emacs-devel@m.gmane.org; Thu, 17 Apr 2014 08:52:52 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:59610) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Walnn-0003vI-FJ for emacs-devel@gnu.org; Thu, 17 Apr 2014 08:52:33 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Walng-0003sn-W3 for emacs-devel@gnu.org; Thu, 17 Apr 2014 08:52:27 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:38358) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Walng-0003sd-RZ for emacs-devel@gnu.org; Thu, 17 Apr 2014 08:52:20 -0400 Original-Received: from pastel.home (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s3HCqFOF021016; Thu, 17 Apr 2014 08:52:16 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 7CAB4600DB; Thu, 17 Apr 2014 08:52:15 -0400 (EDT) In-Reply-To: (Daniel Colascione's message of "Thu, 17 Apr 2014 07:55:28 +0000") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Level: X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0.2 X-NAI-Spam-Rules: 2 Rules triggered TO_ALIAS_IN_SUBJ=0.2, RV4915=0 X-NAI-Spam-Version: 2.3.0.9378 : core <4915> : inlines <744> : streams <1161449> : uri <1732008> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:171468 Archived-At: > * term/xterm.el (xterm-extra-capabilities): Fix bitrotted comment. > (xterm-paste-ending-sequence): New constant. > (xterm-paste): New command used for bracketed paste support. Cool, thanks. Didn't know about that feature of xterm. > + (let ((event (read-event))) > + (when (eql event ?\r) > + (setf event ?\n)) > + (insert event))) A better version would be: (let ((event (read-event))) (insert (if (when (eq event ?\r) ?\n event)))) Note that not only it's better for karma since you don't use setq/setf, but it's also faster. Stefan