From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#17379: 24.3.90.1 pretest: (ag-get-arg 0) somehow returns nil in the middle of advice Date: Wed, 30 Apr 2014 23:54:48 -0400 Message-ID: References: NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1398916528 12789 80.91.229.3 (1 May 2014 03:55:28 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 1 May 2014 03:55:28 +0000 (UTC) Cc: 17379-done@debbugs.gnu.org To: Le Wang Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Thu May 01 05:55:22 2014 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1Wfi5h-00023D-9q for geb-bug-gnu-emacs@m.gmane.org; Thu, 01 May 2014 05:55:21 +0200 Original-Received: from localhost ([::1]:60226 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wfi5g-0005NR-FQ for geb-bug-gnu-emacs@m.gmane.org; Wed, 30 Apr 2014 23:55:20 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:45900) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wfi5X-0005NJ-Bk for bug-gnu-emacs@gnu.org; Wed, 30 Apr 2014 23:55:17 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Wfi5R-000152-6k for bug-gnu-emacs@gnu.org; Wed, 30 Apr 2014 23:55:11 -0400 Original-Received: from debbugs.gnu.org ([140.186.70.43]:57837) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Wfi5R-00014p-3i for bug-gnu-emacs@gnu.org; Wed, 30 Apr 2014 23:55:05 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.80) (envelope-from ) id 1Wfi5Q-0002tD-KJ for bug-gnu-emacs@gnu.org; Wed, 30 Apr 2014 23:55:04 -0400 Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-To: bug-gnu-emacs@gnu.org Resent-Date: Thu, 01 May 2014 03:55:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 17379 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: wontfix Mail-Followup-To: 17379@debbugs.gnu.org, monnier@iro.umontreal.ca, l26wang@gmail.com Original-Received: via spool by 17379-done@debbugs.gnu.org id=D17379.139891649711070 (code D ref 17379); Thu, 01 May 2014 03:55:03 +0000 Original-Received: (at 17379-done) by debbugs.gnu.org; 1 May 2014 03:54:57 +0000 Original-Received: from localhost ([127.0.0.1]:46949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wfi5J-0002sT-AT for submit@debbugs.gnu.org; Wed, 30 Apr 2014 23:54:57 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:47055) by debbugs.gnu.org with esmtp (Exim 4.80) (envelope-from ) id 1Wfi5H-0002s6-4m; Wed, 30 Apr 2014 23:54:56 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArYGAIDvNVPO+K9B/2dsb2JhbABZgwY7gw/APYEXF3SCJQEBAQECAVYjBQsLDiYSFBgNJIgECA3SDBMEjHqCAAeEOASpGYFqgXGBWyE X-IPAS-Result: ArYGAIDvNVPO+K9B/2dsb2JhbABZgwY7gw/APYEXF3SCJQEBAQECAVYjBQsLDiYSFBgNJIgECA3SDBMEjHqCAAeEOASpGYFqgXGBWyE X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="61158327" Original-Received: from 206-248-175-65.dsl.teksavvy.com (HELO pastel.home) ([206.248.175.65]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 30 Apr 2014 23:54:49 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id EBD4D60505; Wed, 30 Apr 2014 23:54:48 -0400 (EDT) In-Reply-To: (Le Wang's message of "Wed, 30 Apr 2014 22:58:41 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.15 Precedence: list X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x X-Received-From: 140.186.70.43 X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Original-Sender: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.bugs:88485 Archived-At: tags 17379 wontfix thanks > Ok the repro steps are very specific. I've tried to make a simpler > repro, but could not with the time I had. > The important 2 line of code is here: > https://github.com/lewang/flx/blob/test-bug-report/flx-ido.el#L226-227 > The advice around it is very basic. The only interesting thing is > after (setq test (ad-get-arg 0)) > test is nil, but original-items is correct. The arglist of ido-set-matches-1 is (items &optional do-full), so (ad-get-arg 0) is `items', which you have rebound to nil. AFAICT, this bug is very old. And, AFAICT, you can't fix it without breaking backward compatibility. The new advice mechanism in 24.4 (i.e. advice-add) does not suffer from these problems, tho. Stefan