From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: wcheck-mode Date: Mon, 07 Jul 2014 10:07:12 -0400 Message-ID: References: <87ob4fg3zp.fsf@gmail.com> <874mzgdm3d.fsf@mithlond.arda> <87r42jd7ld.fsf@mithlond.arda> <83y4wrr822.fsf@gnu.org> <87mwd7d300.fsf@mithlond.arda> <83mwd7qvl2.fsf@gnu.org> <87bntncqe7.fsf@mithlond.arda> <8738ey8kpp.fsf_-_@mithlond.arda> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1404742742 8162 80.91.229.3 (7 Jul 2014 14:19:02 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 7 Jul 2014 14:19:02 +0000 (UTC) Cc: Eli Zaretskii , emacs-devel@gnu.org To: Teemu Likonen Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Mon Jul 07 16:18:55 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X49kg-0006yz-Ly for ged-emacs-devel@m.gmane.org; Mon, 07 Jul 2014 16:18:42 +0200 Original-Received: from localhost ([::1]:50729 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X49a0-000330-Ku for ged-emacs-devel@m.gmane.org; Mon, 07 Jul 2014 10:07:40 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:60213) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X49Zq-00030h-Qb for emacs-devel@gnu.org; Mon, 07 Jul 2014 10:07:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X49Zi-0001ti-EJ for emacs-devel@gnu.org; Mon, 07 Jul 2014 10:07:30 -0400 Original-Received: from ironport2-out.teksavvy.com ([206.248.154.181]:4536) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X49ZZ-0001oH-D0; Mon, 07 Jul 2014 10:07:13 -0400 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCwsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IPAS-Result: ArUGAIDvNVNLd+D9/2dsb2JhbABZgwaDSsA9gRcXdIIlAQEBAQIBViMFCwsOJhIUGA0kiAQI0hkXjnoHhDgEqRmBaoNMIQ X-IronPort-AV: E=Sophos;i="4.97,753,1389762000"; d="scan'208";a="76696074" Original-Received: from 75-119-224-253.dsl.teksavvy.com (HELO pastel.home) ([75.119.224.253]) by ironport2-out.teksavvy.com with ESMTP/TLS/ADH-AES256-SHA; 07 Jul 2014 10:07:12 -0400 Original-Received: by pastel.home (Postfix, from userid 20848) id 434A06038E; Mon, 7 Jul 2014 10:07:12 -0400 (EDT) In-Reply-To: <8738ey8kpp.fsf_-_@mithlond.arda> (Teemu Likonen's message of "Sat, 21 Jun 2014 16:18:26 +0300") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 206.248.154.181 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:172887 Archived-At: > Either way is fine. The papers have been signed so I guess you can just > pull the code. Potentially Emacs developers can improve it. I'm pretty > much of type "I just scratch my own itches" and to me wcheck is about > ready. So I'm not interested in new heavy maintenance burden. But I'm > here and can help. Thanks. I just added it to the `elpa' branch, so the 2014.6.21 version should appear tomorrow-ish on GNU ELPA. >> I have a question: why does it use window-scroll-functions and such >> hooks instead of using jit-lock? > Maybe just because I'm not familiar with jit-lock. Wcheck uses some of > its features, though. Anyway, the idea is to trigger wcheck read event > for after any change in window configuration, buffer content, outline > visibility etc. It's perfectly fine to use other methods if they offer > similar trigger. After a quick look, maybe through jit-lock-register? Yes, jit-lock-register is the right entry point. It should take care of "change in window configuration, buffer content, outline visibility etc..." >> One downside for the user is that ispell.el's M-TAB might not work as >> well since by the time wcheck's timer runs to discover your typo, the >> user might "too far". > Wcheck's "action" feature uses synchronous process to get information > From its back-end program. Maybe wcheck's version of M-TAB feature can > be implemented similar way. I've never used M-TAB, though. I was thinking more of the fact that by the time wcheck has highlighted the misspelled word, the user might be "too far" already, so we'd need to tweak the semantics to be "fix the spelling of the last misspelled word, no matter how far it is", which makes it incompatible with a M-TAB binding (since M-TAB is used for many other things at the same time, we don't want this fix-spelling action to constantly hide the other ones). Stefan