From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: trunk r117960: * etc/TODO: Add a few entries, remove others, expand some Date: Sun, 28 Sep 2014 12:24:29 -0400 Message-ID: References: <868ul4h3pc.fsf@yandex.ru> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1411921509 26656 80.91.229.3 (28 Sep 2014 16:25:09 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 28 Sep 2014 16:25:09 +0000 (UTC) Cc: emacs-devel@gnu.org To: Dmitry Gutov Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Sun Sep 28 18:25:02 2014 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1XYHHS-0000el-Ah for ged-emacs-devel@m.gmane.org; Sun, 28 Sep 2014 18:25:02 +0200 Original-Received: from localhost ([::1]:60295 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYHHR-00029D-Kw for ged-emacs-devel@m.gmane.org; Sun, 28 Sep 2014 12:25:01 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:38291) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYHH9-00028I-1m for emacs-devel@gnu.org; Sun, 28 Sep 2014 12:24:50 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1XYHH1-00019U-He for emacs-devel@gnu.org; Sun, 28 Sep 2014 12:24:42 -0400 Original-Received: from pruche.dit.umontreal.ca ([132.204.246.22]:53026) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1XYHH1-000198-BL for emacs-devel@gnu.org; Sun, 28 Sep 2014 12:24:35 -0400 Original-Received: from fmsmemgm.homelinux.net (lechon.iro.umontreal.ca [132.204.27.242]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id s8SGOR2W019582; Sun, 28 Sep 2014 12:24:27 -0400 Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id 57D3CAE80E; Sun, 28 Sep 2014 12:24:29 -0400 (EDT) In-Reply-To: <868ul4h3pc.fsf@yandex.ru> (Dmitry Gutov's message of "Sun, 28 Sep 2014 06:35:43 +0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4.50 (gnu/linux) X-NAI-Spam-Flag: NO X-NAI-Spam-Threshold: 5 X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV5078=0 X-NAI-Spam-Version: 2.3.0.9378 : core <5078> : inlines <1340> : streams <1302279> : uri <1819203> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 132.204.246.22 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:174775 Archived-At: > Any particular reason for the removal of this item? AFAIK it is now fixed. >> -** Compute the list of active keymaps *after* reading the first event. > After all, at the end of bug#10459, you've called the current solution > an ugly hack. That was not a solution in src.keyboard.c but a workaround in Toby's Elisp code, IIUC. Since then the C code has been changed (see src/keyboard.c:9310: if (NILP (first_event)) { first_event = key; /* Even if first_event does not specify a particular window/position, it's important to recompute the maps here since a long time might have passed since we entered read_key_sequence, and a timer (or process-filter or special-event-map, ...) might have switched the current buffer or the selected window from under us in the mean time. */ if (fix_current_buffer && (XBUFFER (XWINDOW (selected_window)->contents) != current_buffer)) Fset_buffer (XWINDOW (selected_window)->contents); current_binding = active_maps (first_event); } -- Stefan