From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Dmitry Gutov <dgutov@yandex.ru>
Cc: emacs-devel@gnu.org
Subject: Re: trunk r117960: * etc/TODO: Add a few entries, remove others, expand some
Date: Sun, 28 Sep 2014 12:24:29 -0400 [thread overview]
Message-ID: <jwv61g7u33p.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <868ul4h3pc.fsf@yandex.ru> (Dmitry Gutov's message of "Sun, 28 Sep 2014 06:35:43 +0400")
> Any particular reason for the removal of this item?
AFAIK it is now fixed.
>> -** Compute the list of active keymaps *after* reading the first event.
> After all, at the end of bug#10459, you've called the current solution
> an ugly hack.
That was not a solution in src.keyboard.c but a workaround in Toby's
Elisp code, IIUC. Since then the C code has been changed (see
src/keyboard.c:9310:
if (NILP (first_event))
{
first_event = key;
/* Even if first_event does not specify a particular
window/position, it's important to recompute the maps here
since a long time might have passed since we entered
read_key_sequence, and a timer (or process-filter or
special-event-map, ...) might have switched the current buffer
or the selected window from under us in the mean time. */
if (fix_current_buffer
&& (XBUFFER (XWINDOW (selected_window)->contents)
!= current_buffer))
Fset_buffer (XWINDOW (selected_window)->contents);
current_binding = active_maps (first_event);
}
-- Stefan
next prev parent reply other threads:[~2014-09-28 16:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <E1XXdr9-0005lG-Kw@vcs.savannah.gnu.org>
2014-09-28 2:35 ` trunk r117960: * etc/TODO: Add a few entries, remove others, expand some Dmitry Gutov
2014-09-28 16:24 ` Stefan Monnier [this message]
2014-09-29 23:47 ` Dmitry Gutov
2014-09-30 0:28 ` Stefan Monnier
2014-10-05 1:38 ` Dmitry Gutov
2014-10-05 1:54 ` Stefan Monnier
2014-10-05 2:03 ` Dmitry Gutov
2014-10-06 0:58 ` Stefan Monnier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv61g7u33p.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=dgutov@yandex.ru \
--cc=emacs-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.