From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Brittleness of called-interactively-p Date: Thu, 16 Jul 2015 18:55:29 -0400 Message-ID: References: <871tgeufzt.fsf@gmail.com> <87r3odtngi.fsf@gmail.com> <87380st7c1.fsf@gmail.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1437087361 31509 80.91.229.3 (16 Jul 2015 22:56:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 16 Jul 2015 22:56:01 +0000 (UTC) Cc: Dmitri Paduchikh , emacs-devel@gnu.org To: raman Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Fri Jul 17 00:55:52 2015 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZFs4G-0006QX-3E for ged-emacs-devel@m.gmane.org; Fri, 17 Jul 2015 00:55:52 +0200 Original-Received: from localhost ([::1]:42269 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFs4F-0005gM-Am for ged-emacs-devel@m.gmane.org; Thu, 16 Jul 2015 18:55:51 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:34573) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFs43-0005g3-1Z for emacs-devel@gnu.org; Thu, 16 Jul 2015 18:55:39 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZFs3z-0002YP-ST for emacs-devel@gnu.org; Thu, 16 Jul 2015 18:55:38 -0400 Original-Received: from smtp-pri-02-1.vtxnet.net ([212.147.62.146]:35435 helo=smtp-pri-02.vtxnet.net) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZFs3z-0002Y8-Lx for emacs-devel@gnu.org; Thu, 16 Jul 2015 18:55:35 -0400 Original-Received: from localhost (unknown [127.0.0.1]) by smtp-pri-02.vtxnet.net (VTX Services SA) with ESMTP id 2A9B037DD8C; Fri, 17 Jul 2015 00:55:34 +0200 (CEST) Original-Received: from smtp-pri-02.vtxnet.net ([212.147.62.146]) by localhost (smtp-pri-02.vtxnet.net [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id vLn8Yd9n5mbc; Fri, 17 Jul 2015 00:55:30 +0200 (CEST) Original-Received: from fmsmemgm.homelinux.net (dyn.83-228-180-068.dsl.vtx.ch [83.228.180.68]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by smtp-pri-02.vtxnet.net (VTX Services SA) with ESMTP id 30B0437DD88; Fri, 17 Jul 2015 00:55:30 +0200 (CEST) Original-Received: by fmsmemgm.homelinux.net (Postfix, from userid 20848) id C8FA7AE17E; Thu, 16 Jul 2015 18:55:29 -0400 (EDT) In-Reply-To: (raman@google.com's message of "Thu, 16 Jul 2015 08:57:50 -0700") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.0.50 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 212.147.62.146 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.emacs.devel:187912 Archived-At: > When interactive-p was deprecated and we moved to the new > called-interactive-p -- I was unable to get the behavior I wanted using > (called-interactive-p 'interactive) as the test; Are you sure? (interactive-p) is 99.9% equivalent to (called-interactively-p 'interactive), including interactions with advice and whatnot. More recently both functions have been reimplemented, and the new implementation should work about as well as the old one in most cases. The new advice library interacts differently (and that appeared at the same time as the new called-interactively-p implementation), so that can be mistaken as a consequence of the new called-interactively-p implementation, but mostly the new implementation of called-interactively-p mostly handles more cases. Stefan