* Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` [not found] ` <E1ZTaib-0004Wz-Ih@vcs.savannah.gnu.org> @ 2015-08-24 13:37 ` Stefan Monnier 2015-08-24 13:51 ` Nicolas Petton 0 siblings, 1 reply; 7+ messages in thread From: Stefan Monnier @ 2015-08-24 13:37 UTC (permalink / raw) To: emacs-devel; +Cc: Nicolas Petton > Remove the calls to `seq-into` from `seq-concatenate` > Since most new types of seq would have to be defined as sequences (cons > cells or CL structs, mostly), there is no need to convert the seqs to > sequences (which can be a fairly expensive operation). I don't understand this change. Can't it cause two CL-structs to be vconcat'd together, which wouldn't make much sense? Stefan ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` 2015-08-24 13:37 ` [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` Stefan Monnier @ 2015-08-24 13:51 ` Nicolas Petton 2015-08-24 19:23 ` Stefan Monnier 0 siblings, 1 reply; 7+ messages in thread From: Nicolas Petton @ 2015-08-24 13:51 UTC (permalink / raw) To: Stefan Monnier, emacs-devel [-- Attachment #1: Type: text/plain, Size: 727 bytes --] Stefan Monnier <monnier@iro.umontreal.ca> writes: >> Remove the calls to `seq-into` from `seq-concatenate` >> Since most new types of seq would have to be defined as sequences (cons >> cells or CL structs, mostly), there is no need to convert the seqs to >> sequences (which can be a fairly expensive operation). > > I don't understand this change. Can't it cause two CL-structs to be > vconcat'd together, which wouldn't make much sense? The previous version of `seq-concatenate' did not prevent that, since CL-structs are vectors, thus sequences, and the function was using `sequencep' to determine if the seq had to be converted or not. Nico -- Nicolas Petton http://nicolas-petton.fr [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 512 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` 2015-08-24 13:51 ` Nicolas Petton @ 2015-08-24 19:23 ` Stefan Monnier 2015-08-25 8:32 ` Nicolas Petton 0 siblings, 1 reply; 7+ messages in thread From: Stefan Monnier @ 2015-08-24 19:23 UTC (permalink / raw) To: Nicolas Petton; +Cc: emacs-devel >> I don't understand this change. Can't it cause two CL-structs to be >> vconcat'd together, which wouldn't make much sense? > The previous version of `seq-concatenate' did not prevent that, since > CL-structs are vectors, thus sequences, and the function was using > `sequencep' to determine if the seq had to be converted or not. Indeed, but if we intend to work for new "sequence" types defined via CL-struct, that's still a problem. Stefan ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` 2015-08-24 19:23 ` Stefan Monnier @ 2015-08-25 8:32 ` Nicolas Petton 2015-08-25 14:30 ` Stefan Monnier 0 siblings, 1 reply; 7+ messages in thread From: Nicolas Petton @ 2015-08-25 8:32 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel [-- Attachment #1: Type: text/plain, Size: 703 bytes --] Stefan Monnier <monnier@iro.umontreal.ca> writes: >>> I don't understand this change. Can't it cause two CL-structs to be >>> vconcat'd together, which wouldn't make much sense? >> The previous version of `seq-concatenate' did not prevent that, since >> CL-structs are vectors, thus sequences, and the function was using >> `sequencep' to determine if the seq had to be converted or not. > > Indeed, but if we intend to work for new "sequence" types defined via > CL-struct, that's still a problem. Yes, it is still a problem. One solution would be to test if the seq is a cl-struct with, in which case we could use `seq-into'. But then that would only fix the cl-struct case, not any other. Nico [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 512 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` 2015-08-25 8:32 ` Nicolas Petton @ 2015-08-25 14:30 ` Stefan Monnier 2015-08-25 14:48 ` Nicolas Petton 0 siblings, 1 reply; 7+ messages in thread From: Stefan Monnier @ 2015-08-25 14:30 UTC (permalink / raw) To: Nicolas Petton; +Cc: emacs-devel > Yes, it is still a problem. One solution would be to test if the seq is > a cl-struct with, in which case we could use `seq-into'. But then that > would only fix the cl-struct case, not any other. If we make it into a defmethod, at least it would be possible for specific cl-structs to fix the problem. Stefan ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` 2015-08-25 14:30 ` Stefan Monnier @ 2015-08-25 14:48 ` Nicolas Petton 2015-08-25 21:52 ` Stefan Monnier 0 siblings, 1 reply; 7+ messages in thread From: Nicolas Petton @ 2015-08-25 14:48 UTC (permalink / raw) To: Stefan Monnier; +Cc: emacs-devel [-- Attachment #1: Type: text/plain, Size: 551 bytes --] Stefan Monnier <monnier@iro.umontreal.ca> writes: >> Yes, it is still a problem. One solution would be to test if the seq is >> a cl-struct with, in which case we could use `seq-into'. But then that >> would only fix the cl-struct case, not any other. > > If we make it into a defmethod, at least it would be possible for > specific cl-structs to fix the problem. It is already, or did you mean something else? But how would you do it here? There can be any number of sequences. Nico -- Nicolas Petton http://nicolas-petton.fr [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 512 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` 2015-08-25 14:48 ` Nicolas Petton @ 2015-08-25 21:52 ` Stefan Monnier 0 siblings, 0 replies; 7+ messages in thread From: Stefan Monnier @ 2015-08-25 21:52 UTC (permalink / raw) To: Nicolas Petton; +Cc: emacs-devel >>> Yes, it is still a problem. One solution would be to test if the seq is >>> a cl-struct with, in which case we could use `seq-into'. But then that >>> would only fix the cl-struct case, not any other. >> If we make it into a defmethod, at least it would be possible for >> specific cl-structs to fix the problem. > It is already, or did you mean something else? But how would you do it > here? There can be any number of sequences. That's exactly the issue: it needs to be structured so that callers can usefully override it. As it is currently defined, the only overriding possible is to provide new valid values for the `type' argument. So its default definition should make use of seq-into or something similar so that new types can provide their own implementation. E.g., you could define a new (cl-defgeneric seq-into-sequence (seq) (if (sequencep seq) seq (error "Don't know how to turn %S into a sequence" seq))) and then (cl-defgeneric seq-concatenate (type &rest seqs) (apply #'cl-concatenate type (mapcar #'seq-into-sequence seqs))) Stefan ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2015-08-25 21:52 UTC | newest] Thread overview: 7+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20150823191413.17383.23210@vcs.savannah.gnu.org> [not found] ` <E1ZTaib-0004Wz-Ih@vcs.savannah.gnu.org> 2015-08-24 13:37 ` [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` Stefan Monnier 2015-08-24 13:51 ` Nicolas Petton 2015-08-24 19:23 ` Stefan Monnier 2015-08-25 8:32 ` Nicolas Petton 2015-08-25 14:30 ` Stefan Monnier 2015-08-25 14:48 ` Nicolas Petton 2015-08-25 21:52 ` Stefan Monnier
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.