From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Nicolas Petton <nicolas@petton.fr>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate`
Date: Tue, 25 Aug 2015 17:52:47 -0400 [thread overview]
Message-ID: <jwv6143yrok.fsf-monnier+emacsdiffs@gnu.org> (raw)
In-Reply-To: <87vbc3toez.fsf@petton.fr> (Nicolas Petton's message of "Tue, 25 Aug 2015 16:48:04 +0200")
>>> Yes, it is still a problem. One solution would be to test if the seq is
>>> a cl-struct with, in which case we could use `seq-into'. But then that
>>> would only fix the cl-struct case, not any other.
>> If we make it into a defmethod, at least it would be possible for
>> specific cl-structs to fix the problem.
> It is already, or did you mean something else? But how would you do it
> here? There can be any number of sequences.
That's exactly the issue: it needs to be structured so that callers can
usefully override it.
As it is currently defined, the only overriding possible is to provide
new valid values for the `type' argument.
So its default definition should make use of seq-into or something
similar so that new types can provide their own implementation.
E.g., you could define a new
(cl-defgeneric seq-into-sequence (seq)
(if (sequencep seq) seq
(error "Don't know how to turn %S into a sequence" seq)))
and then
(cl-defgeneric seq-concatenate (type &rest seqs)
(apply #'cl-concatenate type (mapcar #'seq-into-sequence seqs)))
Stefan
prev parent reply other threads:[~2015-08-25 21:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20150823191413.17383.23210@vcs.savannah.gnu.org>
[not found] ` <E1ZTaib-0004Wz-Ih@vcs.savannah.gnu.org>
2015-08-24 13:37 ` [Emacs-diffs] master c13a4df: Remove the calls to `seq-into` from `seq-concatenate` Stefan Monnier
2015-08-24 13:51 ` Nicolas Petton
2015-08-24 19:23 ` Stefan Monnier
2015-08-25 8:32 ` Nicolas Petton
2015-08-25 14:30 ` Stefan Monnier
2015-08-25 14:48 ` Nicolas Petton
2015-08-25 21:52 ` Stefan Monnier [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv6143yrok.fsf-monnier+emacsdiffs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=nicolas@petton.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.