all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: emacs-devel@gnu.org
Subject: Re: Don't complain about changed file when it hasn't changed
Date: Tue, 30 Aug 2016 13:16:45 -0400	[thread overview]
Message-ID: <jwv60qiw56z.fsf-monnier+Inbox@gnu.org> (raw)
In-Reply-To: <83twe2mdpu.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 30 Aug 2016 19:19:25 +0300")

>> >  -- Function: ask-user-about-supersession-threat filename
>> >      This function is used to ask a user how to proceed after an attempt
>> >      to modify an buffer visiting file FILENAME when the file is newer
>> >      than the buffer text.  Emacs detects this because the modification
>> >      time of the file on disk is newer than the last save-time of the
>> >      buffer.  This means some other program has probably altered the
>> >      file.
>> 
>> > Some of that will no longer be accurate once we install your changes.
>> 
>> Hmm... actually, this documentation is still valid, because it specifies
>> when the function is called (which is not changed by my patch) rather
>> than what the function does.

> We are splitting hair.

> The problematic place (for me) is the "modification time of the file
> on disk is newer", which implies that this is the only test for the
> detection of supersession-threat.

No, it is the only test made before calling this function (indeed, the
function doesn't make any such test).  My patch doesn't affect this: the
only test performed before calling this function is still the
modtime test.

It's important to know where the test is performed because:

    This function is called automatically by Emacs on the proper
    occasions.  It exists so you can customize Emacs by redefining it.
    See the file @file{userlock.el} for the standard definition.

So if you want to "update the doc" here, we'd have to actually state
what the standard definition does (we currently don't do actually that).


        Stefan



  reply	other threads:[~2016-08-30 17:16 UTC|newest]

Thread overview: 71+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-29  0:29 Don't complain about changed file when it hasn't changed Stefan Monnier
2016-08-29  3:36 ` Clément Pit--Claudel
2016-08-29  3:39   ` Daniel Colascione
2016-08-29  3:43     ` Clément Pit--Claudel
2016-08-29  6:44       ` Michael Albinus
2016-08-29 14:42         ` Eli Zaretskii
2016-08-29 16:18           ` Michael Albinus
2016-08-29 17:42         ` Davis Herring
2016-08-29 17:57           ` Clément Pit--Claudel
2016-08-29 19:10             ` Davis Herring
2016-08-29 13:17   ` Stefan Monnier
2016-08-30  9:20     ` Michael Albinus
2016-08-30 15:00       ` Stefan Monnier
2016-08-30 13:40     ` Clément Pit--Claudel
2016-08-30 15:01       ` Stefan Monnier
2016-08-30 15:23         ` Clément Pit--Claudel
2016-08-30 15:48           ` Stefan Monnier
2016-08-30 16:55             ` Eli Zaretskii
2016-08-30 16:11           ` Eli Zaretskii
2016-08-30 16:38             ` Clément Pit--Claudel
2016-08-29 14:34 ` Eli Zaretskii
2016-08-29 14:50   ` Stefan Monnier
2016-08-30 15:26     ` Eli Zaretskii
2016-08-30 15:44       ` Stefan Monnier
2016-08-30 16:15         ` Eli Zaretskii
2016-08-30 17:13           ` Stefan Monnier
2016-08-30 17:26             ` Eli Zaretskii
2016-08-30 18:02               ` Stefan Monnier
2016-08-30 15:46       ` Stefan Monnier
2016-08-30 16:19         ` Eli Zaretskii
2016-08-30 17:16           ` Stefan Monnier [this message]
2016-08-30 17:32             ` Eli Zaretskii
2016-08-30 18:06               ` Stefan Monnier
2016-09-01 13:49                 ` Eli Zaretskii
2016-09-02 15:22                   ` Stefan Monnier
2016-09-02 15:26                     ` Eli Zaretskii
2016-09-02 15:44                       ` Stefan Monnier
2016-09-02 15:39                     ` Joost Kremers
2016-08-29 16:01   ` Stefan Monnier
2016-08-29 16:26     ` Eli Zaretskii
2016-08-30  0:35       ` Stefan Monnier
2016-08-29 17:50   ` Davis Herring
2016-08-29 18:09     ` Eli Zaretskii
2016-08-29 19:22       ` Davis Herring
2016-08-30  0:39       ` Stefan Monnier
2016-08-30  7:55         ` Andreas Schwab
2016-08-30  0:37     ` Stefan Monnier
2016-08-30  1:23   ` Rolf Ade
2016-08-30 15:12     ` Eli Zaretskii
2016-08-30 15:34       ` Clément Pit--Claudel
2016-08-30 16:14         ` Eli Zaretskii
2016-09-06 16:29 ` John Wiegley
2016-09-06 17:50   ` Stefan Monnier
2016-09-06 17:52     ` John Wiegley
2016-09-06 19:00       ` Andreas Röhler
2016-09-06 21:00         ` Stefan Monnier
2016-09-06 21:29           ` Drew Adams
2016-09-06 21:41     ` Karl Fogel
2016-09-06 21:59       ` Paul Eggert
2016-09-06 22:01         ` Karl Fogel
2016-09-06 22:07           ` Davis Herring
2016-09-06 22:21             ` Karl Fogel
2016-09-06 22:46               ` Clément Pit--Claudel
2016-09-07  0:24               ` Stefan Monnier
2016-09-07 16:49                 ` Karl Fogel
2016-09-07 18:41                   ` Andreas Röhler
2016-09-07 20:02                     ` Karl Fogel
2016-09-06 22:03         ` Karl Fogel
2016-12-24  1:03 ` Rolf Ade
2016-12-25 15:44   ` Stefan Monnier
2016-12-26  0:29     ` Rolf Ade

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv60qiw56z.fsf-monnier+Inbox@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=eliz@gnu.org \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.