all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
From: Stefan Monnier <monnier@iro.umontreal.ca>
To: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix
Date: Wed, 14 Dec 2016 13:15:32 -0500	[thread overview]
Message-ID: <jwv60mmfkk3.fsf-monnier+gmane.emacs.devel@gnu.org> (raw)
In-Reply-To: 8ek2b25ubu.fsf@fencepost.gnu.org

> I hear what you're saying. I'm usually not a fan of excessive argument
> checking, but this case seemed ok to me. But I don't feel much about
> it either way, so if you want to revert it and close the associated
> reports as wontfix, that's totally fine by me.

The funny thing is that we have a similar arg check in fmakunbound
(which I removed in my local Emacs a long time ago), and the OP
actually tried to undo his mistake using `fmakunbound` but bumped into
that other excessive checking, which prevented him from fixing this
first mistake (of course, (fset nil nil) would have worked, but it
didn't occur to him).


        Stefan




  reply	other threads:[~2016-12-14 18:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161212202151.21054.37035@vcs.savannah.gnu.org>
     [not found] ` <20161212202152.428192201BB@vcs.savannah.gnu.org>
2016-12-13 13:40   ` [Emacs-diffs] master 61f8c23 1/2: Minor advice.el fix Stefan Monnier
2016-12-14 16:49     ` Glenn Morris
2016-12-14 18:15       ` Stefan Monnier [this message]
2016-12-17 21:11     ` Philipp Stephani
2016-12-17 22:08       ` Stefan Monnier
2016-12-18 19:43         ` Philipp Stephani
2016-12-18 20:15           ` Stefan Monnier
2016-12-23 12:20             ` Philipp Stephani
2016-12-24  1:21               ` Stefan Monnier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=jwv60mmfkk3.fsf-monnier+gmane.emacs.devel@gnu.org \
    --to=monnier@iro.umontreal.ca \
    --cc=emacs-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.