* Re: [Emacs-diffs] master 2349f1d: Turn global-eldoc-mode into a globalized minor mode [not found] ` <20170529235540.48D1C20ACA@vcs0.savannah.gnu.org> @ 2017-05-30 4:09 ` Stefan Monnier 2017-05-30 22:37 ` Dmitry Gutov 0 siblings, 1 reply; 4+ messages in thread From: Stefan Monnier @ 2017-05-30 4:09 UTC (permalink / raw) To: emacs-devel; +Cc: Dmitry Gutov > ((memq eldoc-documentation-function '(nil ignore)) [...] > + (unless (memq eldoc-documentation-function '(nil ignore)) It'd probably be best to move this out into its own function so if we ever change the test at one spot, we also change the other spot accordingly. Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 2349f1d: Turn global-eldoc-mode into a globalized minor mode 2017-05-30 4:09 ` [Emacs-diffs] master 2349f1d: Turn global-eldoc-mode into a globalized minor mode Stefan Monnier @ 2017-05-30 22:37 ` Dmitry Gutov 2017-05-31 11:54 ` Stefan Monnier 0 siblings, 1 reply; 4+ messages in thread From: Dmitry Gutov @ 2017-05-30 22:37 UTC (permalink / raw) To: Stefan Monnier, emacs-devel On 5/30/17 7:09 AM, Stefan Monnier wrote: >> ((memq eldoc-documentation-function '(nil ignore)) > [...] >> + (unless (memq eldoc-documentation-function '(nil ignore)) > > It'd probably be best to move this out into its own function so if we > ever change the test at one spot, we also change the other > spot accordingly. OK, done. Thinking about this, though, I'm not sure this is ideal. First, this setup is sensitive to the order in which minor modes are enabled. Which is, in theory, arbitrary. Second, suppose the user enables an eldoc-enabling-mode manually with 'M-x'. They'll have to 'M-x eldoc-mode' manually afterwards for the desired effect. ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 2349f1d: Turn global-eldoc-mode into a globalized minor mode 2017-05-30 22:37 ` Dmitry Gutov @ 2017-05-31 11:54 ` Stefan Monnier 2017-05-31 12:15 ` Dmitry Gutov 0 siblings, 1 reply; 4+ messages in thread From: Stefan Monnier @ 2017-05-31 11:54 UTC (permalink / raw) To: emacs-devel > Second, suppose the user enables an eldoc-enabling-mode manually with > 'M-x'. They'll have to 'M-x eldoc-mode' manually afterwards for the > desired effect. I think it's fair to assume that the "eldoc-enabling-mode" could go to the trouble to enable eldoc-mode for the user in that case. Stefan ^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Emacs-diffs] master 2349f1d: Turn global-eldoc-mode into a globalized minor mode 2017-05-31 11:54 ` Stefan Monnier @ 2017-05-31 12:15 ` Dmitry Gutov 0 siblings, 0 replies; 4+ messages in thread From: Dmitry Gutov @ 2017-05-31 12:15 UTC (permalink / raw) To: Stefan Monnier, emacs-devel On 5/31/17 2:54 PM, Stefan Monnier wrote: > I think it's fair to assume that the "eldoc-enabling-mode" could go to > the trouble to enable eldoc-mode for the user in that case. Except we don't document that it should. And the developer likely didn't test this option. Anyway, we'll get to it when we get to it. ^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2017-05-31 12:15 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20170529235539.23360.19169@vcs0.savannah.gnu.org>
[not found] ` <20170529235540.48D1C20ACA@vcs0.savannah.gnu.org>
2017-05-30 4:09 ` [Emacs-diffs] master 2349f1d: Turn global-eldoc-mode into a globalized minor mode Stefan Monnier
2017-05-30 22:37 ` Dmitry Gutov
2017-05-31 11:54 ` Stefan Monnier
2017-05-31 12:15 ` Dmitry Gutov
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.