From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Glenn Morris <rgm@gnu.org>
Cc: 30455@debbugs.gnu.org, John <jpff@codemist.co.uk>
Subject: bug#30455: 27.0.50; problem in diary-remind
Date: Thu, 15 Feb 2018 00:43:24 -0500 [thread overview]
Message-ID: <jwv606ylsgk.fsf-monnier+emacsbugs@gnu.org> (raw)
In-Reply-To: <65d1174fxa.fsf@fencepost.gnu.org> (Glenn Morris's message of "Wed, 14 Feb 2018 12:52:33 -0500")
> I imagine this is lexical-binding fallout. Please could you take a look?
> Thanks.
>
> Minimal example diary-file contents:
>
> %%(diary-remind '(diary-date 3 1 2018) -20 t)
I wasn't able to reproduce the problem, but looking at the code, I think
I figured the problem and installed the patch below which might fix it.
Could you or John confirm that it fixes the original problem?
Stefan
diff --git a/lisp/calendar/diary-lib.el b/lisp/calendar/diary-lib.el
index 181b1172fa..acf4b20d77 100644
--- a/lisp/calendar/diary-lib.el
+++ b/lisp/calendar/diary-lib.el
@@ -2049,7 +2049,8 @@ diary-remind
(when (setq diary-entry (eval sexp))
;; Discard any mark portion from diary-anniversary, etc.
(if (consp diary-entry) (setq diary-entry (cdr diary-entry)))
- (mapconcat #'eval diary-remind-message ""))))
+ (calendar-dlet* ((days days))
+ (mapconcat #'eval diary-remind-message "")))))
;; Diary entry may apply to one of a list of days before date.
((and (listp days) days)
(or (diary-remind sexp (car days) marking)
next prev parent reply other threads:[~2018-02-15 5:43 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-14 15:06 bug#30455: 27.0.50; problem in diary-remind John
2018-02-14 17:52 ` Glenn Morris
2018-02-14 20:25 ` Stefan Monnier
2018-02-15 5:43 ` Stefan Monnier [this message]
2018-02-15 7:29 ` Glenn Morris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv606ylsgk.fsf-monnier+emacsbugs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=30455@debbugs.gnu.org \
--cc=jpff@codemist.co.uk \
--cc=rgm@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.