From: Stefan Monnier <monnier@IRO.UMontreal.CA>
To: Eli Zaretskii <eliz@gnu.org>
Cc: yurivkhan@gmail.com, 33749@debbugs.gnu.org
Subject: bug#33749: 26.1; input-decode-map to empty vector should preserve echo area
Date: Tue, 25 Dec 2018 15:07:50 -0500 [thread overview]
Message-ID: <jwv5zvhz8cy.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <835zvh8k7x.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 25 Dec 2018 21:44:34 +0200")
>> I think The Right Thing to do is likely to move this code to
>> read_key_sequence, more specifically, move it to the point where we
>> *know* we really do have an event.
>> IOW, I think the patch below might be a better option (where we test
>> `indec.start > 0` to make sure some *decoded* event was read).
> Where in that patch is the variable that I asked for, which would
> trigger this special behavior?
Nowhere ;-)
Mostly because I don't know where we could set this variable (other
than globally).
If you want me to add a global var to control whether we use the old or
the new behavior, I'm fine with that.
Note also that the current patch is likely not quite right yet anyway:
I mostly posted it for discussion. E.g. I think where I put it
currently, it fails to be run for single-key commands.
Stefan
next prev parent reply other threads:[~2018-12-25 20:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-14 20:48 bug#33749: 26.1; input-decode-map to empty vector should preserve echo area Yuri Khan
2018-12-15 6:57 ` Eli Zaretskii
2018-12-15 8:07 ` Yuri Khan
2018-12-15 9:09 ` Eli Zaretskii
2018-12-16 8:29 ` bug#33749: [PATCH] Preserve echo area contents when decoding an empty key sequence (Bug#33749) Yuri Khan
2018-12-19 18:05 ` bug#33749: 26.1; input-decode-map to empty vector should preserve echo area Stefan Monnier
2018-12-20 17:33 ` Yuri Khan
2018-12-20 18:56 ` Stefan Monnier
2018-12-21 18:36 ` Yuri Khan
2018-12-25 19:35 ` Stefan Monnier
2018-12-25 19:44 ` Eli Zaretskii
2018-12-25 20:07 ` Stefan Monnier [this message]
2018-12-26 3:32 ` Eli Zaretskii
2019-01-01 16:09 ` Yuri Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv5zvhz8cy.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=33749@debbugs.gnu.org \
--cc=eliz@gnu.org \
--cc=yurivkhan@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.