From: Stefan Monnier <monnier@iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi@gnus.org>
Cc: emacs-devel@gnu.org
Subject: Re: [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt
Date: Sun, 16 Jun 2019 16:24:00 -0400 [thread overview]
Message-ID: <jwv5zp5xp2a.fsf-monnier+emacs@gnu.org> (raw)
In-Reply-To: <m3wohliaeb.fsf@gnus.org> (Lars Ingebrigtsen's message of "Sun, 16 Jun 2019 21:43:24 +0200")
>>> +(require 'cl-extra)
>> Please require cl-lib instead: the division into cl-(lib|macs|seq|extra)
>> is supposed to be an internal implementation detail.
> That's what I had originally, but then I got this warning:
> In end of data:
> emacs-lisp/eieio-opt.el:359:1:Warning: the function `cl--describe-class' is
> not known to be defined.
> Perhaps because it's an internal(ish) function?
Ah, yes, it's not autoloaded because it's internal.
I guess cl-extra is OK in that case, but please add a comment to
explain it.
Stefan
next prev parent reply other threads:[~2019-06-16 20:24 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20190616141010.24607.84378@vcs0.savannah.gnu.org>
[not found] ` <20190616141013.5EE5F20B45@vcs0.savannah.gnu.org>
2019-06-16 19:41 ` [Emacs-diffs] master bf8c80b 4/5: Compilation fix for previous change to eieio-opt Stefan Monnier
2019-06-16 19:43 ` Lars Ingebrigtsen
2019-06-16 19:52 ` Lars Ingebrigtsen
2019-06-16 19:55 ` Lars Ingebrigtsen
2019-06-16 20:24 ` Stefan Monnier [this message]
2019-06-16 20:26 ` Lars Ingebrigtsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=jwv5zp5xp2a.fsf-monnier+emacs@gnu.org \
--to=monnier@iro.umontreal.ca \
--cc=emacs-devel@gnu.org \
--cc=larsi@gnus.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this external index
https://git.savannah.gnu.org/cgit/emacs.git
https://git.savannah.gnu.org/cgit/emacs/org-mode.git
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.