From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 3586fef: Make HIST arg of read-from-minibuffer work with buffer-local vars Date: Thu, 05 Dec 2019 14:17:43 -0500 Message-ID: References: <20191205093041.3243.23144@vcs0.savannah.gnu.org> <20191205093043.1A8E0209BE@vcs0.savannah.gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: blaine.gmane.org; posting-host="blaine.gmane.org:195.159.176.226"; logging-data="114335"; mail-complaints-to="usenet@blaine.gmane.org" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Federico Tedin Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Thu Dec 05 20:19:12 2019 Return-path: Envelope-to: ged-emacs-devel@m.gmane.org Original-Received: from lists.gnu.org ([209.51.188.17]) by blaine.gmane.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1icwed-000Tcb-5i for ged-emacs-devel@m.gmane.org; Thu, 05 Dec 2019 20:19:11 +0100 Original-Received: from localhost ([::1]:60044 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icweb-00011z-N0 for ged-emacs-devel@m.gmane.org; Thu, 05 Dec 2019 14:19:09 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:36675) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1icwdn-0000d5-Fw for emacs-devel@gnu.org; Thu, 05 Dec 2019 14:18:20 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1icwdi-0005N5-34 for emacs-devel@gnu.org; Thu, 05 Dec 2019 14:18:16 -0500 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:36403) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1icwdK-0005IU-CN for emacs-devel@gnu.org; Thu, 05 Dec 2019 14:17:54 -0500 Original-Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 07B28100473; Thu, 5 Dec 2019 14:17:47 -0500 (EST) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 117B11000ED; Thu, 5 Dec 2019 14:17:45 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1575573465; bh=gs2EuxDQvdEOR+lu54nEzCQaCdx4hPO2zUzRw7E19no=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=S7wjK21Qd1whp5XR2ba0Av6K2W63DRmY8nAzjWC/QVFJs8kKd2VmfOGNc8fvq35yp 6vWZgANIXsxV2xD/CfdfiJPODZcqEvb5S8JTdyNwebA69ZAXfFs8kG3bpOyZhQfQYQ mlPZYEe07ehbfegWZNylQbBN3rq2EwiiIzyeTK821u7BpfAKaOctsmblu7GZq/7eD7 Nr2GrxjWfdraYQmBksx20EbR+M0vB2vQ/KpMk3O/NX/Jow86EHYuZqW6tMfPbKf+dZ 5KHFAdJJoOIHi+BsFmBLqWltObxL1d7sSjH7fAKdjWeOe865c9rX5ltRJ2Csn/6rDB eBNjODLc79vow== Original-Received: from lechazo (lechon.iro.umontreal.ca [132.204.27.242]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id EEA6A1202D5; Thu, 5 Dec 2019 14:17:44 -0500 (EST) In-Reply-To: (Federico Tedin's message of "Thu, 5 Dec 2019 17:50:48 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.org gmane.emacs.devel:243171 Archived-At: >> Note that this `add-to-history` call takes place at the very end of >> read_minibuf, hence just *before* we return to previous_buffer. >> Maybe a simpler option than the code above is to postpone the code >> a little bit so that it takes place *after* we return to >> previous_buffer. > Would that mean moving the `add-to-history' call to after the final call > to `unbind_to(count, val)'? Yes, I think that's basically all it takes. Stefan