From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.ciao.gmane.io!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: Multiple definitions of explicit-shell-file-name Date: Thu, 16 Apr 2020 10:12:04 -0400 Message-ID: References: <871rooz4fx.fsf@tcd.ie> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="ciao.gmane.io:159.69.161.202"; logging-data="51558"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: "Basil L. Contovounesios" Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Thu Apr 16 16:13:02 2020 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1jP5GH-000DHq-GK for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Apr 2020 16:13:01 +0200 Original-Received: from localhost ([::1]:34744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP5GG-0001ma-IM for ged-emacs-devel@m.gmane-mx.org; Thu, 16 Apr 2020 10:13:00 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:38771) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jP5FS-0000VW-LU for emacs-devel@gnu.org; Thu, 16 Apr 2020 10:12:11 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jP5FQ-0003eW-Di for emacs-devel@gnu.org; Thu, 16 Apr 2020 10:12:09 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:59157) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jP5FQ-0003eK-7I for emacs-devel@gnu.org; Thu, 16 Apr 2020 10:12:08 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 6AABE811DE; Thu, 16 Apr 2020 10:12:07 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id C2964806B9; Thu, 16 Apr 2020 10:12:05 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1587046325; bh=It3gw63eQ/edE4KCs4Md9bXFJhqAM+UUUiJZu+EsD0k=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=hfQdsKf3PU1fIq/v9P+09BZHUz0gol6dHIhnRiv5QmbLU1fe4KKEQ1WGvf2JX9Kwg uhN6cfvQTit3p1LGg/837/e0sUnYj3rchE8YHthh95C49i95X6l4DrNddyE93PEOXW 0k27BAqE9sdFvYxDkDDHgBstp85wCdzapjn85QxdkXzHuTNtkfbrj/TApQ96lUvr9R Jfh32x5JQSF6mh8ovqr6uMYnW/jCuFevFuh0+ROqGTrgAJf0bB6tLg7G0lH7EKh/09 2tX/34me3p7sIcVVZHomhWwtK4uPsY6XV8LJO8Ff+MhHK8mNwBnInWMkBaXwY4f2+y UuB2T5LClsTKA== Original-Received: from alfajor (unknown [104.247.241.114]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 8F6251201E7; Thu, 16 Apr 2020 10:12:05 -0400 (EDT) In-Reply-To: <871rooz4fx.fsf@tcd.ie> (Basil L. Contovounesios's message of "Thu, 16 Apr 2020 00:58:58 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 132.204.25.50 X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:247088 Archived-At: > I noticed that explicit-shell-file-name has been defined as a user > option in three different places since at least as far back as 1997: > > - lisp/shell.el > - lisp/term.el > - lisp/obsolete/terminal.el > > Each file also assigns it a different custom :group. Can we consolidate > these duplicates in a single place such as lisp/simple.el, as follows? I don't think it belongs in simple.el. It should be in shell.el. Stefan