From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.bugs Subject: bug#13521: `sort-lines' on the empty region Date: Sat, 05 Sep 2020 11:34:22 -0400 Message-ID: References: <20130122085354.75ced82538551655e724e0ea@gmail.com>> > > > > <83mu2objro.fsf@gnu.org>> > <83imdcbgc5.fsf@gnu.org>> > <83imcspim8.fsf@gnu.org>> <3aad96d8-2503-40e8-b684-8ed18a089083@default> <83a6y4p98g.fsf@gnu.org> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="23580"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) Cc: xfq.free@gmail.com, rgm@gnu.org, stefan@marxist.se, 13521@debbugs.gnu.org To: Eli Zaretskii Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Sat Sep 05 17:35:10 2020 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kEaDe-000614-Oi for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 17:35:10 +0200 Original-Received: from localhost ([::1]:59640 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kEaDd-0006z1-Ra for geb-bug-gnu-emacs@m.gmane-mx.org; Sat, 05 Sep 2020 11:35:09 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:45092) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kEaDW-0006x7-IH for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:35:02 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:60589) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kEaDW-0004z4-8P for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:35:02 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kEaDW-0004jl-4o for bug-gnu-emacs@gnu.org; Sat, 05 Sep 2020 11:35:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 05 Sep 2020 15:35:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 13521 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch Original-Received: via spool by 13521-submit@debbugs.gnu.org id=B13521.159932007418171 (code B ref 13521); Sat, 05 Sep 2020 15:35:02 +0000 Original-Received: (at 13521) by debbugs.gnu.org; 5 Sep 2020 15:34:34 +0000 Original-Received: from localhost ([127.0.0.1]:43902 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEaD4-0004j1-8Q for submit@debbugs.gnu.org; Sat, 05 Sep 2020 11:34:34 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:61245) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kEaD2-0004ip-M5 for 13521@debbugs.gnu.org; Sat, 05 Sep 2020 11:34:33 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 5743A80B69; Sat, 5 Sep 2020 11:34:27 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id E61D0809A1; Sat, 5 Sep 2020 11:34:24 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1599320064; bh=PsGXkQwczLLm7axJXi5JxxlwEDWDiD2SQO0v4/5je7E=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Rj2AGE0u4EQ1BWpLMugbbujJQ7FN28++NA6eri68RgUt8gVjWPEcwRUnIuGCAmNcl jJOyZVaSI7tlKhLfzDewVGa8DwYGfImbmuvMGa4TV9pJnfBL92Pu4uq8pSoAQLLxW0 A7VkATBH/egMvFAOd+apP/297jNAThZp6wzyhPVY7o5RD5Alew3O0P+Ofkcm1Q3zjm zSCiK3OE3+zc+PX5soxGjP+ZG2KZ0zoSOhVpiF9SNGCn0It/4R/TdKIBMyGmvW13Ov beEPfzLCcougN/tbGtZiL+Yjx3JkJ/SwMZJlcbJhqe1B/mklnytw1lcJilm7bRnEhJ NuPgjLDTVNimA== Original-Received: from alfajor (unknown [45.72.232.131]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 913A6120604; Sat, 5 Sep 2020 11:34:24 -0400 (EDT) In-Reply-To: <83a6y4p98g.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 05 Sep 2020 17:51:43 +0300") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:187268 Archived-At: > The important point here is that sort-lines worked on the region, even > if inactive, before the proposed changes, so restricting it now only > to active regions would be a backward-incompatible change of behavior. Indeed, so the patch should check something like (if (or (null transient-mark-mode) (use-region-p)) (list (region-beginning) (region-end)) (list (point-min) (point-max))) `use-region-p` checks `transient-mark-mode` the other way, because it's used mostly for commands which previously did *not* operate on the region, unlike `sort-lines`. Stefan