* Re: master 431b098: * lisp/emacs-lisp/pcase.el (let): Reimplement as a pcase macro [not found] ` <20210205200801.C912720DFE@vcs0.savannah.gnu.org> @ 2021-02-06 11:07 ` Basil L. Contovounesios 2021-02-07 4:14 ` Stefan Monnier 0 siblings, 1 reply; 2+ messages in thread From: Basil L. Contovounesios @ 2021-02-06 11:07 UTC (permalink / raw) To: emacs-devel; +Cc: Stefan Monnier monnier@iro.umontreal.ca (Stefan Monnier) writes: > branch: master > commit 431b098a206d27a2dff6a88312c28c36926f90e9 > Author: Stefan Monnier <monnier@iro.umontreal.ca> > Commit: Stefan Monnier <monnier@iro.umontreal.ca> > > * lisp/emacs-lisp/pcase.el (let): Reimplement as a pcase macro > > (pcase--macroexpand, pcase--u1): Remove handling of `let` from > `pcase`s core. Does this mean (info "(elisp) pcase Macro") has to be updated, e.g. to document (let ...) alongside (rx ...) as another "built-in" pattern, or can we still pretend (let ...) is a "core" pattern for documentation purposes? Thanks, -- Basil ^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: master 431b098: * lisp/emacs-lisp/pcase.el (let): Reimplement as a pcase macro 2021-02-06 11:07 ` master 431b098: * lisp/emacs-lisp/pcase.el (let): Reimplement as a pcase macro Basil L. Contovounesios @ 2021-02-07 4:14 ` Stefan Monnier 0 siblings, 0 replies; 2+ messages in thread From: Stefan Monnier @ 2021-02-07 4:14 UTC (permalink / raw) To: Basil L. Contovounesios; +Cc: emacs-devel > Does this mean (info "(elisp) pcase Macro") has to be updated, e.g. to > document (let ...) alongside (rx ...) as another "built-in" pattern, or > can we still pretend (let ...) is a "core" pattern for documentation > purposes? It's indeed not a "core" pattern any more, but just like with specialforms-vs-macros, the difference between core patterns and built-in patterns is just an internal implementation detail, and the way I read the Texinfo doc, I don't see such a distinction: `rx` is (oddly) placed together with `and` and `or`, which are both core patterns. BTW, regarding the `grok/pcase` example, maybe the doc should make it more clear that this example is a contrived piece of code intended to combine as many of `pcase`s features as possible, and doesn't intend to encourage using such style (which I personally find horrendous ;-). Stefan ^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-07 4:14 UTC | newest] Thread overview: 2+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- [not found] <20210205200800.6254.9111@vcs0.savannah.gnu.org> [not found] ` <20210205200801.C912720DFE@vcs0.savannah.gnu.org> 2021-02-06 11:07 ` master 431b098: * lisp/emacs-lisp/pcase.el (let): Reimplement as a pcase macro Basil L. Contovounesios 2021-02-07 4:14 ` Stefan Monnier
Code repositories for project(s) associated with this external index https://git.savannah.gnu.org/cgit/emacs.git https://git.savannah.gnu.org/cgit/emacs/org-mode.git This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.