all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed
* [ELPA] New package: taxy-magit-section
@ 2021-09-24  5:46 Adam Porter
  2021-09-27 18:05 ` Stefan Monnier
  0 siblings, 1 reply; 9+ messages in thread
From: Adam Porter @ 2021-09-24  5:46 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 240 bytes --]

Hi Stefan, et al,

Having developed it a bit, I'd like to split taxy-magit-section into a
separate package while keeping it in the same git repo.  Please see the
attached patch to elpa-packages; I hope I did it correctly.

-- 
Thanks,
Adam

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-elpa-packages-taxy-taxy-magit-section-Update-add.patch --]
[-- Type: text/x-diff, Size: 1003 bytes --]

From 1675e898380003c6ffdb10318ab700e6b51b0427 Mon Sep 17 00:00:00 2001
From: Adam Porter <adam@alphapapa.net>
Date: Fri, 24 Sep 2021 05:34:37 +0000
Subject: [PATCH] * elpa-packages (taxy, taxy-magit-section): Update/add

---
 elpa-packages | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index cffd9a63ca..514ed04fd0 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -373,6 +373,11 @@
  ("system-packages"	:url "https://gitlab.com/jabranham/system-packages")
  ("systemd"		:url nil)
  ("taxy"                :url "https://github.com/alphapapa/taxy.el.git"
+  :doc "taxy.info"
+  :ignored-files ("taxy-magit-section.el" "images")
+  :auto-sync t)
+ ("taxy-magit-section"  :url "https://github.com/alphapapa/taxy.el.git"
+  :ignored-files ("taxy.el" "examples" "images" "taxy.info")
   :auto-sync t)
  ("temp-buffer-browse"  :url "https://github.com/leoliu/temp-buffer-browse")
  ("test-simple"         :url "https://github.com/rocky/emacs-test-simple")
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [ELPA] New package: taxy-magit-section
  2021-09-24  5:46 [ELPA] New package: taxy-magit-section Adam Porter
@ 2021-09-27 18:05 ` Stefan Monnier
  2021-09-28  5:58   ` Adam Porter
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2021-09-27 18:05 UTC (permalink / raw)
  To: Adam Porter; +Cc: emacs-devel

> Having developed it a bit, I'd like to split taxy-magit-section into a
> separate package while keeping it in the same git repo.  Please see the
> attached patch to elpa-packages; I hope I did it correctly.

It looks correct in the sense that it should work and give the right
result, but it's *much* better to try and avoid such situations by
splitting it into a separate repository/branch: releasing several ELPA
packages from the same repository introduces various problems (none of
them really serious, luckily, so it will work but it's better avoided).


        Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ELPA] New package: taxy-magit-section
  2021-09-27 18:05 ` Stefan Monnier
@ 2021-09-28  5:58   ` Adam Porter
  2021-10-05  6:34     ` Adam Porter
  0 siblings, 1 reply; 9+ messages in thread
From: Adam Porter @ 2021-09-28  5:58 UTC (permalink / raw)
  To: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> Having developed it a bit, I'd like to split taxy-magit-section into a
>> separate package while keeping it in the same git repo.  Please see the
>> attached patch to elpa-packages; I hope I did it correctly.
>
> It looks correct in the sense that it should work and give the right
> result, but it's *much* better to try and avoid such situations by
> splitting it into a separate repository/branch: releasing several ELPA
> packages from the same repository introduces various problems (none of
> them really serious, luckily, so it will work but it's better avoided).

Okay, I'll see about putting it in a separate branch.  Thanks.




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ELPA] New package: taxy-magit-section
  2021-09-28  5:58   ` Adam Porter
@ 2021-10-05  6:34     ` Adam Porter
  2021-10-06 20:59       ` Stefan Monnier
  0 siblings, 1 reply; 9+ messages in thread
From: Adam Porter @ 2021-10-05  6:34 UTC (permalink / raw)
  To: emacs-devel

[-- Attachment #1: Type: text/plain, Size: 752 bytes --]

Hi Stefan,

> Stefan Monnier <monnier@iro.umontreal.ca> writes:
>
>>> Having developed it a bit, I'd like to split taxy-magit-section into a
>>> separate package while keeping it in the same git repo.  Please see the
>>> attached patch to elpa-packages; I hope I did it correctly.
>>
>> It looks correct in the sense that it should work and give the right
>> result, but it's *much* better to try and avoid such situations by
>> splitting it into a separate repository/branch: releasing several ELPA
>> packages from the same repository introduces various problems (none of
>> them really serious, luckily, so it will work but it's better avoided).

I've moved taxy-magit-section.el to a separate branch in the taxy.el
repo.  Here's an updated patch:


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-elpa-packages-taxy-taxy-magit-section-Update-add.patch --]
[-- Type: text/x-diff, Size: 985 bytes --]

From e13670366f679b5a1af82c605f67a0fc46d9e90f Mon Sep 17 00:00:00 2001
From: Adam Porter <adam@alphapapa.net>
Date: Fri, 24 Sep 2021 05:34:37 +0000
Subject: [PATCH] * elpa-packages (taxy, taxy-magit-section): Update/add

---
 elpa-packages | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/elpa-packages b/elpa-packages
index 96b6f55..0bdcb69 100644
--- a/elpa-packages
+++ b/elpa-packages
@@ -385,6 +385,12 @@
  ("system-packages"	:url "https://gitlab.com/jabranham/system-packages")
  ("systemd"		:url nil)
  ("taxy"                :url "https://github.com/alphapapa/taxy.el.git"
+  :doc "taxy.info"
+  :ignored-files ("images")
+  :auto-sync t)
+ ("taxy-magit-section"  :url "https://github.com/alphapapa/taxy.el.git"
+  :branch "package/taxy-magit-section"
+  :doc "taxy-magit-section.info"
   :auto-sync t)
  ("temp-buffer-browse"  :url "https://github.com/leoliu/temp-buffer-browse")
  ("test-simple"         :url "https://github.com/rocky/emacs-test-simple")
-- 
2.7.4


[-- Attachment #3: Type: text/plain, Size: 17 bytes --]


--
Thanks,
Adam

^ permalink raw reply related	[flat|nested] 9+ messages in thread

* Re: [ELPA] New package: taxy-magit-section
  2021-10-05  6:34     ` Adam Porter
@ 2021-10-06 20:59       ` Stefan Monnier
  2021-10-07 16:46         ` Adam Porter
  0 siblings, 1 reply; 9+ messages in thread
From: Stefan Monnier @ 2021-10-06 20:59 UTC (permalink / raw)
  To: Adam Porter; +Cc: emacs-devel

> diff --git a/elpa-packages b/elpa-packages
> index 96b6f55..0bdcb69 100644
> --- a/elpa-packages
> +++ b/elpa-packages
> @@ -385,6 +385,12 @@
>   ("system-packages"	:url "https://gitlab.com/jabranham/system-packages")
>   ("systemd"		:url nil)
>   ("taxy"                :url "https://github.com/alphapapa/taxy.el.git"
> +  :doc "taxy.info"
> +  :ignored-files ("images")
> +  :auto-sync t)
> + ("taxy-magit-section"  :url "https://github.com/alphapapa/taxy.el.git"
> +  :branch "package/taxy-magit-section"
> +  :doc "taxy-magit-section.info"
>    :auto-sync t)
>   ("temp-buffer-browse"  :url "https://github.com/leoliu/temp-buffer-browse")
>   ("test-simple"         :url "https://github.com/rocky/emacs-test-simple")

Thanks, installed.

But please note that it would be much better not to store the `.info`
files in the repository (the general rule is that you only want to
store *source* files in there) and instead use

    :doc "README.org"


-- Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ELPA] New package: taxy-magit-section
  2021-10-06 20:59       ` Stefan Monnier
@ 2021-10-07 16:46         ` Adam Porter
  2021-10-07 17:21           ` Stefan Monnier
  0 siblings, 1 reply; 9+ messages in thread
From: Adam Porter @ 2021-10-07 16:46 UTC (permalink / raw)
  To: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

> Thanks, installed.

Thanks.

> But please note that it would be much better not to store the `.info`
> files in the repository (the general rule is that you only want to
> store *source* files in there) and instead use
>
>     :doc "README.org"

I'd generally be glad to do that.  I did it myself when the README.org
file is saved because that's necessary for my packages that are on
MELPA.  I wouldn't mind for ELPA to do that automatically, however there
is one issue: users who install the package by other means, like with
Quelpa (as I do for some of my own packages, so I don't have to wait for
(M)ELPA to build them) or Straight wouldn't get the info manual, IIUC.

Also, it can be helpful for me to see the diffs in the generated info
manual when I'm committing changes to the readme.

So, for now at least, I'd prefer to keep them in the repo and generate
them myself, if that's acceptable.




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ELPA] New package: taxy-magit-section
  2021-10-07 16:46         ` Adam Porter
@ 2021-10-07 17:21           ` Stefan Monnier
  2021-10-07 17:51             ` Adam Porter
  2021-10-07 18:24             ` dick
  0 siblings, 2 replies; 9+ messages in thread
From: Stefan Monnier @ 2021-10-07 17:21 UTC (permalink / raw)
  To: Adam Porter; +Cc: emacs-devel

> I'd generally be glad to do that.  I did it myself when the README.org
> file is saved because that's necessary for my packages that are on
> MELPA.

I'm not sure what's the benefit of having packages on MELPA when they're
already in GNU ELPA, to be honest.

> I wouldn't mind for ELPA to do that automatically, however there
> is one issue: users who install the package by other means, like with
> Quelpa (as I do for some of my own packages, so I don't have to wait for
> (M)ELPA to build them) or Straight wouldn't get the info manual, IIUC.

They'd need to generate it, just like `elpa-admin.el` would do, indeed.

> So, for now at least, I'd prefer to keep them in the repo and generate
> them myself, if that's acceptable.

It's fully up to you.


        Stefan




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ELPA] New package: taxy-magit-section
  2021-10-07 17:21           ` Stefan Monnier
@ 2021-10-07 17:51             ` Adam Porter
  2021-10-07 18:24             ` dick
  1 sibling, 0 replies; 9+ messages in thread
From: Adam Porter @ 2021-10-07 17:51 UTC (permalink / raw)
  To: emacs-devel

Stefan Monnier <monnier@iro.umontreal.ca> writes:

>> I'd generally be glad to do that.  I did it myself when the README.org
>> file is saved because that's necessary for my packages that are on
>> MELPA.
>
> I'm not sure what's the benefit of having packages on MELPA when they're
> already in GNU ELPA, to be honest.

To be clear, I didn't mean that this one is on MELPA and GNU ELPA.  I
meant that I copied that pattern from other packages of mine that are on
MELPA.  :)




^ permalink raw reply	[flat|nested] 9+ messages in thread

* Re: [ELPA] New package: taxy-magit-section
  2021-10-07 17:21           ` Stefan Monnier
  2021-10-07 17:51             ` Adam Porter
@ 2021-10-07 18:24             ` dick
  1 sibling, 0 replies; 9+ messages in thread
From: dick @ 2021-10-07 18:24 UTC (permalink / raw)
  Cc: emacs-devel

SM> I'm not sure what's the benefit of having packages on MELPA when they're
SM> already in GNU ELPA, to be honest.

Wow, shots fired!

The answer of course is the same reason why a Target, Walmart, or Amazon
eventually sells eggs and milk on top of whatever knickknacks they originally
sold.  One-stop shopping is a user tropism.  That's why emacs clings to relevance.



^ permalink raw reply	[flat|nested] 9+ messages in thread

end of thread, other threads:[~2021-10-07 18:24 UTC | newest]

Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-09-24  5:46 [ELPA] New package: taxy-magit-section Adam Porter
2021-09-27 18:05 ` Stefan Monnier
2021-09-28  5:58   ` Adam Porter
2021-10-05  6:34     ` Adam Porter
2021-10-06 20:59       ` Stefan Monnier
2021-10-07 16:46         ` Adam Porter
2021-10-07 17:21           ` Stefan Monnier
2021-10-07 17:51             ` Adam Porter
2021-10-07 18:24             ` dick

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.