Re: [nongnu] elpa/clojure-mode f8989ab615: Let the byte-compiler know about dynamic var

all messages for Emacs-related lists mirrored at yhetil.org
 help / color / mirror / code / Atom feed

* Re: [nongnu] elpa/clojure-mode f8989ab615: Let the byte-compiler know about dynamic var
       [not found] ` <20220202110212.D3908C002F7@vcs2.savannah.gnu.org>
@ 2022-02-02 13:23   ` Stefan Monnier
  2022-02-02 13:40     ` Bozhidar Batsov
  0 siblings, 1 reply; 2+ messages in thread
From: Stefan Monnier @ 2022-02-02 13:23 UTC (permalink / raw)
  To: Magnar Sveen; +Cc: emacs-devel

>  (eval-when-compile
>    (defvar calculate-lisp-indent-last-sexp)
> +  (defvar delete-pair-blink-delay)
>    (defvar font-lock-beg)
>    (defvar font-lock-end)
>    (defvar paredit-space-for-delimiter-predicates)

`defvar` (when given a single argument) is a compiler directive whose
execution has no effect.

The fact that it also works when placed inside `eval-when-compile` is an
accident (and a bug: it should only affect the rest of the code within
the `eval-when-compile`).

Please move those out of `eval-when-compile`.

        Stefan

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [nongnu] elpa/clojure-mode f8989ab615: Let the byte-compiler know about dynamic var
  2022-02-02 13:23   ` [nongnu] elpa/clojure-mode f8989ab615: Let the byte-compiler know about dynamic var Stefan Monnier
@ 2022-02-02 13:40     ` Bozhidar Batsov
  0 siblings, 0 replies; 2+ messages in thread
From: Bozhidar Batsov @ 2022-02-02 13:40 UTC (permalink / raw)
  To: Emacs Devel

[-- Attachment #1: Type: text/plain, Size: 702 bytes --]

Thanks for the feedback. I'll change this right away. 

On Wed, Feb 2, 2022, at 3:23 PM, Stefan Monnier wrote:
> >  (eval-when-compile
> >    (defvar calculate-lisp-indent-last-sexp)
> > +  (defvar delete-pair-blink-delay)
> >    (defvar font-lock-beg)
> >    (defvar font-lock-end)
> >    (defvar paredit-space-for-delimiter-predicates)
> 
> `defvar` (when given a single argument) is a compiler directive whose
> execution has no effect.
> 
> The fact that it also works when placed inside `eval-when-compile` is an
> accident (and a bug: it should only affect the rest of the code within
> the `eval-when-compile`).
> 
> Please move those out of `eval-when-compile`.
> 
> 
>         Stefan
> 
> 
> 

[-- Attachment #2: Type: text/html, Size: 1325 bytes --]

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-02-02 13:40 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
     [not found] <164379973260.10900.5488380383299537790@vcs2.savannah.gnu.org>
     [not found] ` <20220202110212.D3908C002F7@vcs2.savannah.gnu.org>
2022-02-02 13:23   ` [nongnu] elpa/clojure-mode f8989ab615: Let the byte-compiler know about dynamic var Stefan Monnier
2022-02-02 13:40     ` Bozhidar Batsov

Code repositories for project(s) associated with this external index

	https://git.savannah.gnu.org/cgit/emacs.git
	https://git.savannah.gnu.org/cgit/emacs/org-mode.git

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.