From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier Newsgroups: gmane.emacs.devel Subject: Re: master 18ec3fcce9: Restore pending_signals at a point in the DND event loop Date: Sun, 17 Apr 2022 01:21:34 -0400 Message-ID: References: <165015596397.5558.5393619769224500857@vcs2.savannah.gnu.org> <20220417003924.49D86C01684@vcs2.savannah.gnu.org> <87sfqcnz2s.fsf@yahoo.com> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36665"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: emacs-devel@gnu.org To: Po Lu Original-X-From: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Sun Apr 17 07:22:54 2022 Return-path: Envelope-to: ged-emacs-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nfxN7-0009JY-MG for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Apr 2022 07:22:53 +0200 Original-Received: from localhost ([::1]:38418 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nfxN6-0006g7-Gb for ged-emacs-devel@m.gmane-mx.org; Sun, 17 Apr 2022 01:22:52 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:46760) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfxLy-0005Fd-CC for emacs-devel@gnu.org; Sun, 17 Apr 2022 01:21:42 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:52579) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nfxLv-0003XG-Hh for emacs-devel@gnu.org; Sun, 17 Apr 2022 01:21:41 -0400 Original-Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id AA996802B7; Sun, 17 Apr 2022 01:21:37 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 7A9BD8050D; Sun, 17 Apr 2022 01:21:36 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1650172896; bh=coOdWCyJZorzU21FNdmDDxpaFt9JBADPyRsM9ckXfCo=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Nq/QwKgdmrhOJ+VfSXWwNjKbNq3fbpj9j+0d7gIBe870b1+O/ro7uJyvU8Empwyuy IstXc7btOVmpDpzxOnsGbB1P+HHpUo5eNuBprOhNF8zMqtzIYGFdCb4gqP3yfhmiix jk51nhokmviz4o1Z5uhkMeL+5YDYWbLzkIq5x6GytcLg/HQ4nF1k4yMDsucPjruS6L bnCzv9j8/DTEh7GNq+P3lGNzdA1Mh/BA5ikWV9xTZTkz7IayYsDNluw9FhBT4ikvNH 2eoURi5VO7RP5ytFrW6LPoQ6hcgIaJn1tOyl8Kg8WUWhzUH5fSZWTxtD/GcZFhRZ12 iSi1wdF4flAmQ== Original-Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 2F4A712047F; Sun, 17 Apr 2022 01:21:36 -0400 (EDT) In-Reply-To: <87sfqcnz2s.fsf@yahoo.com> (Po Lu's message of "Sun, 17 Apr 2022 11:55:23 +0800") Received-SPF: pass client-ip=132.204.25.50; envelope-from=monnier@iro.umontreal.ca; helo=mailscanner.iro.umontreal.ca X-Spam_score_int: -42 X-Spam_score: -4.3 X-Spam_bar: ---- X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, T_SCC_BODY_TEXT_LINE=-0.01 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: emacs-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Emacs development discussions." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: emacs-devel-bounces+ged-emacs-devel=m.gmane-mx.org@gnu.org Original-Sender: "Emacs-devel" Xref: news.gmane.io gmane.emacs.devel:288524 Archived-At: Po Lu [2022-04-17 11:55:23] wrote: > Stefan Monnier writes: >> This is pretty ugly. >> Why is it that it "does nothing"? Any hope we can move this restoration >> of `pending_signals` closer to the code that "does nothing"? > No, because we don't know the prior value of `pending_signals' in that > code. How bout the first question? Also, I'm pretty sure the real answer isn't "no" because we can surely move it to the place where `pending_signals` is changed and that is closer at least in terms of "dynamic distance". > In general, the interaction between async input and the event loop run > during a drag is pretty confusing, especially on GTK+. And we should make this complexity much more explicit in the code rather than add magic hacks linked via occasional comments. Stefan