From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Stefan Monnier via "Bug reports for GNU Emacs, the Swiss army knife of text editors" Newsgroups: gmane.emacs.bugs Subject: bug#55038: 29.0.50; Does macroexp-file-name return nil unnecessarily? Date: Thu, 21 Apr 2022 09:20:22 -0400 Message-ID: References: <875yn3zw07.fsf@posteo.net> Reply-To: Stefan Monnier Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="28906"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) Cc: 55038@debbugs.gnu.org To: Philip Kaludercic Original-X-From: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Thu Apr 21 15:26:40 2022 Return-path: Envelope-to: geb-bug-gnu-emacs@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nhWpT-0007Hl-UR for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Apr 2022 15:26:40 +0200 Original-Received: from localhost ([::1]:50562 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1nhWpS-0003JR-O0 for geb-bug-gnu-emacs@m.gmane-mx.org; Thu, 21 Apr 2022 09:26:38 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:58236) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1nhWk4-0005XS-A9 for bug-gnu-emacs@gnu.org; Thu, 21 Apr 2022 09:21:05 -0400 Original-Received: from debbugs.gnu.org ([209.51.188.43]:54798) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1nhWk2-0000Z4-7P for bug-gnu-emacs@gnu.org; Thu, 21 Apr 2022 09:21:03 -0400 Original-Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1nhWk2-0002fV-3i for bug-gnu-emacs@gnu.org; Thu, 21 Apr 2022 09:21:02 -0400 X-Loop: help-debbugs@gnu.org Resent-From: Stefan Monnier Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 21 Apr 2022 13:21:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 55038 X-GNU-PR-Package: emacs Original-Received: via spool by 55038-submit@debbugs.gnu.org id=B55038.165054723610191 (code B ref 55038); Thu, 21 Apr 2022 13:21:02 +0000 Original-Received: (at 55038) by debbugs.gnu.org; 21 Apr 2022 13:20:36 +0000 Original-Received: from localhost ([127.0.0.1]:48694 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhWjb-0002eG-FU for submit@debbugs.gnu.org; Thu, 21 Apr 2022 09:20:35 -0400 Original-Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:11429) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nhWjY-0002e0-Cu for 55038@debbugs.gnu.org; Thu, 21 Apr 2022 09:20:33 -0400 Original-Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id F041A4421F5; Thu, 21 Apr 2022 09:20:26 -0400 (EDT) Original-Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 933334421CE; Thu, 21 Apr 2022 09:20:25 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1650547225; bh=KHN2lQFfKt3/ZF9L0HlIkw5q+/AWeqPPLzv0T5c7jrw=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=Hri/ST+frMNGfh+oi8KUgDlTHMAEin4x7+kHSvyEUelWRI8/fAbaZt4tfZkGqN1Cn LBa2vl56JRLU51e9G+bWg4q7lZJdluUB+i3G45fYmkh8YM+OwkFfYmm6PbObw7b58U a32Ssun79TcgJdeXGi4dRR7Gq6zF2lOw+eHsK4v+oGMVW8fqwRH5ULuFCQdW493b7f 9ovc8bfhMD/epkDa5FF7l1fqsc5tYYA5K2wiBNlvI2wUrsBH3iOdRE+FNbhE5vCxyr D5Xz/fFKvpYxcL5MwiKKVhlCAtdCIcvx4PJAK6W7Z1cZcK3hlO2/GmBXUbBCH27oeX trpPl3BXbnazA== Original-Received: from alfajor (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 31BD7120296; Thu, 21 Apr 2022 09:20:25 -0400 (EDT) In-Reply-To: <875yn3zw07.fsf@posteo.net> (Philip Kaludercic's message of "Wed, 20 Apr 2022 14:10:00 +0000") X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: bug-gnu-emacs@gnu.org List-Id: "Bug reports for GNU Emacs, the Swiss army knife of text editors" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: bug-gnu-emacs-bounces+geb-bug-gnu-emacs=m.gmane-mx.org@gnu.org Original-Sender: "bug-gnu-emacs" Xref: news.gmane.io gmane.emacs.bugs:230362 Archived-At: > Consider a macro like > > (defmacro foo () > `(message "Defined in %s" ,(macroexp-file-name))) > > Why does this expand to > > (message "Defined in %s" nil) > > when evaluated directly in a file (say using `eval-buffer' or > `eval-last-sexp`). No good reason. > Shouldn't it be fair to return the file name of the buffer, if nothing > else can be used: In the case the code comes from the current buffer, yes. OTOH if it comes from (say) `M-:`, no. > diff --git a/lisp/emacs-lisp/macroexp.el b/lisp/emacs-lisp/macroexp.el > index e4bc2df280..5df9d4b221 100644 > --- a/lisp/emacs-lisp/macroexp.el > +++ b/lisp/emacs-lisp/macroexp.el > @@ -143,7 +143,8 @@ macroexp-file-name > ;; so prefer using it over using `load-file-name'. > (let ((file (car (last current-load-list)))) > (or (if (stringp file) file) > - (bound-and-true-p byte-compile-current-file)))) > + (bound-and-true-p byte-compile-current-file) > + (buffer-file-name)))) I think we need to make `eval-buffer` and friends set a variable to indicate when `buffer-file-name` can be used. Stefan